linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Mathieu Malaterre <malat@debian.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] lib/mpi: fix build with clang
Date: Tue, 25 Jun 2019 04:03:04 +0000	[thread overview]
Message-ID: <CACPK8XdM7eub41ig2MBxX7BJpAsVbuL4HO9VM_5bR5BuXEX89A@mail.gmail.com> (raw)
In-Reply-To: <20190621195555.20615-1-malat@debian.org>

On Fri, 21 Jun 2019 at 19:56, Mathieu Malaterre <malat@debian.org> wrote:
>
> Remove superfluous casts on output operands to avoid warnings on the
> following macros:
>
> * add_ssaaaa(sh, sl, ah, al, bh, bl)
> * sub_ddmmss(sh, sl, ah, al, bh, bl)
> * umul_ppmm(ph, pl, m0, m1)
>
> Special care has been taken to keep the diff as minimal as possible from
> the original header file `longlong.h` from gcc, only importing the
> minimal change to make the compilation with clang pass.


> Suggested-by: Joel Stanley <joel@jms.id.au>
> Cc: Segher Boessenkool <segher@kernel.crashing.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> v2: Instead of passing compat flag to clang to behave as gcc, remove the superfluous cast

Thanks, I checked your patch against GCC's longlong.h and it looks good.

Reviewed-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel

  reply	other threads:[~2019-06-25  4:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  7:13 [PATCH] crypto: Fix build for clang Mathieu Malaterre
2019-06-21  7:29 ` Joel Stanley
2019-06-21  7:44   ` Mathieu Malaterre
2019-06-21 19:55 ` [PATCH v2] lib/mpi: fix build with clang Mathieu Malaterre
2019-06-25  4:03   ` Joel Stanley [this message]
2019-06-25 18:15   ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPK8XdM7eub41ig2MBxX7BJpAsVbuL4HO9VM_5bR5BuXEX89A@mail.gmail.com \
    --to=joel@jms.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malat@debian.org \
    --cc=mpe@ellerman.id.au \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).