linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Jeffery <andrew@aj.id.au>,
	Lee Jones <lee.jones@linaro.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 3/3] reset: simple: Allow user selection of driver
Date: Mon, 19 Feb 2018 22:37:55 +1030	[thread overview]
Message-ID: <CACPK8Xe3bKSfp=PqL8Rm9ivaM5HN0M7FbJ9Bwf_O2D5MZxEpPQ@mail.gmail.com> (raw)
In-Reply-To: <1519040779.3408.7.camel@pengutronix.de>

On Mon, Feb 19, 2018 at 10:16 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote:
>> Currently this driver is only user selectable if COMPILE_TEST is turned
>> on. Users may wish to select (and deselect) it, so remove this
>> restriction.
>
> I would like to keep user visible options to a minimum unless there is a
> good reason. What is the scenario in which a user would decide to
> disable the default-enabled reset-simple driver, or the other way
> around? This should be mentioned in the commit message.

In this SoC's case the driver is not essential. A system that does not
use UART1..4 will not ever call on the driver. This situation is
common as the console uses UART5.

> Maybe this is an indication that there could be a better default than
> just ARCH_ASPEED.

This is an appropriate default, as it causes the least surprise to a
user. Without taking the UART out of reset, the kernel driver still
loads, but characters are never drained from the FIFO.

Advanced users may want to save the few kilobytes that an extra driver
adds, and the boot overhead of loading yet another driver. The saving
is small, so if you feel strongly about it we can drop this patch.

Cheers,

Joel

>
> regards
> Philipp
>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>>  drivers/reset/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> index 18f152d251d7..7490a4370900 100644
>> --- a/drivers/reset/Kconfig
>> +++ b/drivers/reset/Kconfig
>> @@ -82,7 +82,7 @@ config RESET_PISTACHIO
>>         This enables the reset driver for ImgTec Pistachio SoCs.
>>
>>  config RESET_SIMPLE
>> -     bool "Simple Reset Controller Driver" if COMPILE_TEST
>> +     bool "Simple Reset Controller Driver"
>>       default ARCH_SOCFPGA || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX || ARCH_ASPEED
>>       help
>>         This enables a simple reset controller driver for reset lines that

  reply	other threads:[~2018-02-19 12:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19  6:54 [PATCH 0/3] reset: simple: enable for ASPEED SoCs Joel Stanley
2018-02-19  6:54 ` [PATCH 1/3] dt-bindings: aspeed-lpc: Add reset controller Joel Stanley
2018-02-19 11:46   ` Philipp Zabel
2018-02-19 12:00     ` Joel Stanley
2018-02-19 20:41   ` Rob Herring
2018-02-19  6:54 ` [PATCH 2/3] reset: simple: Enable for ASPEED systems Joel Stanley
2018-02-19  6:54 ` [PATCH 3/3] reset: simple: Allow user selection of driver Joel Stanley
2018-02-19 11:46   ` Philipp Zabel
2018-02-19 12:07     ` Joel Stanley [this message]
2018-02-19 11:46 ` [PATCH 0/3] reset: simple: enable for ASPEED SoCs Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8Xe3bKSfp=PqL8Rm9ivaM5HN0M7FbJ9Bwf_O2D5MZxEpPQ@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=andrew@aj.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).