From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC28C10DAA for ; Wed, 9 Sep 2020 06:57:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72D2721D7F for ; Wed, 9 Sep 2020 06:57:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="mYuIK7PT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbgIIG5M (ORCPT ); Wed, 9 Sep 2020 02:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbgIIG5L (ORCPT ); Wed, 9 Sep 2020 02:57:11 -0400 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF174C061573; Tue, 8 Sep 2020 23:57:10 -0700 (PDT) Received: by mail-ed1-x541.google.com with SMTP id q21so1531692edv.1; Tue, 08 Sep 2020 23:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aucFnAaA6n54SqN2ylDW2Uq1+nK592raJ0MmLzBKiSs=; b=mYuIK7PT4ChKZXdBvVrAd7YKq7i/4lwweyhypREg+ye6C6cYuYWQo2zLiWiUGH+tWe 6q6Clmjyx92I7Ed1bHBx7IQzZQc90V8ILbwtoZk/4SAT8ccv3Jo/4cM6wi8z41LJ4v3l DSWkf02+8QQ86flhs7lTLOQvzv0X58zrRLhLo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aucFnAaA6n54SqN2ylDW2Uq1+nK592raJ0MmLzBKiSs=; b=g9mlM9R9Hx9Id5uOFiKHhS/o/RuRP/glVKQnZdUJTGP1XsdANsB3VfXP20ux3BSUdW jcjHVi0qO6EcAMHAFjyZNghpGX3kQgYMtu8eTO1iRPem4cf5L3Gh84ihj3VJ01ZddNtx SLnto1z+yEZthl74w+GYBbHNYb8WEl/V3izJx1LDVOVq04nokh01Dsu44hlF2/d5yphj 28uyM8seCa1xNgqQE08caVo/n0OPcUUCwg0s8YRN+cGMyVlB5mwh8HPuIUR3WQZNVxFG r5wa6AIs4tTVyFipzBYG/pFnPPD3qzmHMJNlSWTnp4C6k5Z/7MHDkh8kx0YelWI8UuJo Wwnw== X-Gm-Message-State: AOAM530ZRZHoN+gx1GkdbaW6FD9ZzgZ/be0nMbp6Ic6dEWS9WJDPAAi0 cA/G9/GZacPrhkq353h7+5cC0Hit7VwiR7pOa3g= X-Google-Smtp-Source: ABdhPJwPlzh1DnLGo9MSTT8J/yrnEnx7UmuC9FQVeFtz+arOOvvLH5XkI0R9H39kuPOE/iZLcwtZShJUK72WQR+TAXI= X-Received: by 2002:a05:6402:ca7:: with SMTP id cn7mr2599331edb.143.1599634629657; Tue, 08 Sep 2020 23:57:09 -0700 (PDT) MIME-Version: 1.0 References: <20200908200101.64974-1-eajames@linux.ibm.com> <20200908200101.64974-5-eajames@linux.ibm.com> In-Reply-To: <20200908200101.64974-5-eajames@linux.ibm.com> From: Joel Stanley Date: Wed, 9 Sep 2020 06:56:57 +0000 Message-ID: Subject: Re: [PATCH v2 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device To: Eddie James Cc: linux-input@vger.kernel.org, devicetree , Linux Kernel Mailing List , linux-aspeed , linux-i2c@vger.kernel.org, Andrew Jeffery , Benjamin Herrenschmidt , Brendan Higgins , dmitry.torokhov@gmail.com, Rob Herring , wsa@kernel.org, Tao Ren , Ryan Chen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Sep 2020 at 20:01, Eddie James wrote: > > Set I2C bus 0 to multi-master mode and add the panel device that will > register as a slave. > > Signed-off-by: Eddie James > Reviewed-by: Joel Stanley I will take this and the rainier dts patch through the aspeed tree so we don't get conflicts. Eddie, when you send v3, you can omit them. Cheers, Joel > --- > arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > index 5f4ee67ac787..4d070d6ba09f 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts > @@ -4,6 +4,7 @@ > > #include "aspeed-g6.dtsi" > #include > +#include > #include > > / { > @@ -438,7 +439,13 @@ aliases { > }; > > &i2c0 { > + multi-master; > status = "okay"; > + > + ibm-panel@62 { > + compatible = "ibm,op-panel"; > + reg = <(0x62 | I2C_OWN_SLAVE_ADDRESS)>; > + }; > }; > > &i2c1 { > -- > 2.26.2 >