* [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma
@ 2020-10-16 4:35 Andrew Jeffery
2020-10-16 4:35 ` [PATCH 1/2] ARM: dts: rainier: Add reserved memory for ramoops Andrew Jeffery
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andrew Jeffery @ 2020-10-16 4:35 UTC (permalink / raw)
To: joel; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Hi,
We're looking to improve our crash data capture for the BMC on some IBM
platforms. This small series enables ramoops for Rainier and Tacoma.
Please review.
Andrew
Andrew Jeffery (2):
ARM: dts: rainier: Add reserved memory for ramoops
ARM: dts: tacoma: Add reserved memory for ramoops
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 9 +++++++++
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 9 +++++++++
2 files changed, 18 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: rainier: Add reserved memory for ramoops
2020-10-16 4:35 [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma Andrew Jeffery
@ 2020-10-16 4:35 ` Andrew Jeffery
2020-10-16 4:35 ` [PATCH 2/2] ARM: dts: tacoma: " Andrew Jeffery
2020-10-21 4:51 ` [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma Joel Stanley
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Jeffery @ 2020-10-16 4:35 UTC (permalink / raw)
To: joel; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Reserve a 1.5MiB region of memory to record kmsg dumps, console and
userspace message state into 16kiB ring-buffer slots. The sizing allows
for up to 32 dumps to be captured and read out.
Set max-reason to KMSG_DUMP_EMERG to capture bad-path reboots.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 183e1a4dcc65..89729ee698c5 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -47,6 +47,15 @@ reserved-memory {
#size-cells = <1>;
ranges;
+ ramoops@b7e80000 {
+ compatible = "ramoops";
+ reg = <0xb7e80000 0x180000>;
+ record-size = <0x4000>;
+ console-size = <0x4000>;
+ pmsg-size = <0x4000>;
+ max-reason = <3>; /* KMSG_DUMP_EMERG */
+ };
+
flash_memory: region@b8000000 {
no-map;
reg = <0xb8000000 0x04000000>; /* 64M */
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: tacoma: Add reserved memory for ramoops
2020-10-16 4:35 [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma Andrew Jeffery
2020-10-16 4:35 ` [PATCH 1/2] ARM: dts: rainier: Add reserved memory for ramoops Andrew Jeffery
@ 2020-10-16 4:35 ` Andrew Jeffery
2020-10-21 5:05 ` Joel Stanley
2020-10-21 4:51 ` [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma Joel Stanley
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Jeffery @ 2020-10-16 4:35 UTC (permalink / raw)
To: joel; +Cc: robh+dt, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Reserve a 1.5MiB region of memory to record kmsg dumps, console and
userspace message state into 16kiB ring-buffer slots. The sizing allows
for up to 32 dumps to be captured and read out.
Set max-reason to KMSG_DUMP_EMERG to capture bad-path reboots.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
index 46f2f538baba..4f7e9b490e1a 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
@@ -26,6 +26,15 @@ reserved-memory {
#size-cells = <1>;
ranges;
+ ramoops@b9e80000 {
+ compatible = "ramoops";
+ reg = <0xb9e80000 0x180000>;
+ record-size = <0x4000>;
+ console-size = <0x4000>;
+ pmsg-size = <0x4000>;
+ max-reason = <3>; /* KMSG_DUMP_EMERG */
+ };
+
flash_memory: region@ba000000 {
no-map;
reg = <0xb8000000 0x4000000>; /* 64M */
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma
2020-10-16 4:35 [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma Andrew Jeffery
2020-10-16 4:35 ` [PATCH 1/2] ARM: dts: rainier: Add reserved memory for ramoops Andrew Jeffery
2020-10-16 4:35 ` [PATCH 2/2] ARM: dts: tacoma: " Andrew Jeffery
@ 2020-10-21 4:51 ` Joel Stanley
2 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2020-10-21 4:51 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Rob Herring, devicetree, Linux ARM, linux-aspeed,
Linux Kernel Mailing List
On Fri, 16 Oct 2020 at 04:36, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> Hi,
>
> We're looking to improve our crash data capture for the BMC on some IBM
> platforms. This small series enables ramoops for Rainier and Tacoma.
>
> Please review.
Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Andrew
>
> Andrew Jeffery (2):
> ARM: dts: rainier: Add reserved memory for ramoops
> ARM: dts: tacoma: Add reserved memory for ramoops
>
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 9 +++++++++
> arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 9 +++++++++
> 2 files changed, 18 insertions(+)
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: tacoma: Add reserved memory for ramoops
2020-10-16 4:35 ` [PATCH 2/2] ARM: dts: tacoma: " Andrew Jeffery
@ 2020-10-21 5:05 ` Joel Stanley
2020-10-21 5:42 ` Andrew Jeffery
0 siblings, 1 reply; 6+ messages in thread
From: Joel Stanley @ 2020-10-21 5:05 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Rob Herring, devicetree, Linux ARM, linux-aspeed,
Linux Kernel Mailing List
On Fri, 16 Oct 2020 at 04:36, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> Reserve a 1.5MiB region of memory to record kmsg dumps, console and
> userspace message state into 16kiB ring-buffer slots. The sizing allows
> for up to 32 dumps to be captured and read out.
>
> Set max-reason to KMSG_DUMP_EMERG to capture bad-path reboots.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> index 46f2f538baba..4f7e9b490e1a 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> @@ -26,6 +26,15 @@ reserved-memory {
> #size-cells = <1>;
> ranges;
>
> + ramoops@b9e80000 {
> + compatible = "ramoops";
> + reg = <0xb9e80000 0x180000>;
I take that r-b back. When booting, we see:
[ 0.000000] region@ba000000 (0xb8000000--0xbc000000) overlaps with
ramoops@b9e80000 (0xb9e80000--0xba000000)
Which appears to be a true statement.
> + record-size = <0x4000>;
> + console-size = <0x4000>;
> + pmsg-size = <0x4000>;
> + max-reason = <3>; /* KMSG_DUMP_EMERG */
> + };
> +
> flash_memory: region@ba000000 {
> no-map;
> reg = <0xb8000000 0x4000000>; /* 64M */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: tacoma: Add reserved memory for ramoops
2020-10-21 5:05 ` Joel Stanley
@ 2020-10-21 5:42 ` Andrew Jeffery
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Jeffery @ 2020-10-21 5:42 UTC (permalink / raw)
To: Joel Stanley
Cc: Rob Herring, devicetree, Linux ARM, linux-aspeed,
Linux Kernel Mailing List
On Wed, 21 Oct 2020, at 15:35, Joel Stanley wrote:
> On Fri, 16 Oct 2020 at 04:36, Andrew Jeffery <andrew@aj.id.au> wrote:
> >
> > Reserve a 1.5MiB region of memory to record kmsg dumps, console and
> > userspace message state into 16kiB ring-buffer slots. The sizing allows
> > for up to 32 dumps to be captured and read out.
> >
> > Set max-reason to KMSG_DUMP_EMERG to capture bad-path reboots.
> >
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> > index 46f2f538baba..4f7e9b490e1a 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts
> > @@ -26,6 +26,15 @@ reserved-memory {
> > #size-cells = <1>;
> > ranges;
> >
> > + ramoops@b9e80000 {
> > + compatible = "ramoops";
> > + reg = <0xb9e80000 0x180000>;
>
> I take that r-b back. When booting, we see:
>
> [ 0.000000] region@ba000000 (0xb8000000--0xbc000000) overlaps with
> ramoops@b9e80000 (0xb9e80000--0xba000000)
>
> Which appears to be a true statement.
Yep:
>
> > + record-size = <0x4000>;
> > + console-size = <0x4000>;
> > + pmsg-size = <0x4000>;
> > + max-reason = <3>; /* KMSG_DUMP_EMERG */
> > + };
> > +
> > flash_memory: region@ba000000 {
> > no-map;
> > reg = <0xb8000000 0x4000000>; /* 64M */
Looks like I derived the ramoops address from the flash_memory node label, but
that's mismatched with its reg value.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-21 5:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 4:35 [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma Andrew Jeffery
2020-10-16 4:35 ` [PATCH 1/2] ARM: dts: rainier: Add reserved memory for ramoops Andrew Jeffery
2020-10-16 4:35 ` [PATCH 2/2] ARM: dts: tacoma: " Andrew Jeffery
2020-10-21 5:05 ` Joel Stanley
2020-10-21 5:42 ` Andrew Jeffery
2020-10-21 4:51 ` [PATCH 0/2] ARM: dts: Enable ramoops for Rainier and Tacoma Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).