From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75,URIBL_BLOCKED, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1D0C35240 for ; Fri, 31 Jan 2020 03:57:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 818722082E for ; Fri, 31 Jan 2020 03:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="noyHcUPq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728025AbgAaD5o (ORCPT ); Thu, 30 Jan 2020 22:57:44 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:43500 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbgAaD5o (ORCPT ); Thu, 30 Jan 2020 22:57:44 -0500 Received: by mail-qv1-f65.google.com with SMTP id p2so2629396qvo.10; Thu, 30 Jan 2020 19:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OS9mBViSnpsx15jMubvsBFiHBkNyIzUT3w9rd7Dkm/4=; b=noyHcUPqJ0I5pWCEXCl8lIoSgyMPfW1Alr3FH8Icy2qTfIQG6tC7f5iR6GJJgBlvBH Zj7O6G0hnO+elulx3q0wMDv6N602q09EdFidsG+RazZIn6kKV15MIrMncnKEIg7BjvDf MGBpMYvNY0vc8PhsLTtRl7c4xih/i7Kz7jHZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OS9mBViSnpsx15jMubvsBFiHBkNyIzUT3w9rd7Dkm/4=; b=RfKP5siitwCr8+Lan9g6BTulFi+Kvngs8IsNx5/2PBXrOCdmBgPvdHg9uupUVlcLfB z7Z/Yh93Hbd0ONRPtdj3Vz2I6O5+S7JgYn36JE4sB0DHcOmmt+WSUj6OGzgtFE1uJF31 /VNIxlwJVoh8l+m+EGZ7wpuFGn1Cm7vm2+DAaMCH4i0DZ2SyprtHXvQv+OaXvEN2JJHH rDfV+6OP8AAhrMqWSQhEgHMD8jByrmGAFqFWJuvT9aVqmuFQoMiQd4xRULD74jXl9d/2 Uasg08s1EbdpQcxU84RNOBdCk1KPfkNzfqRq7AaZddGOxhGZU21x1Bv/HoY+C+nRCGHx fhBg== X-Gm-Message-State: APjAAAXCTNlWGAe15Z0n9MyN1P5hZ5OWc7ETtqe9BXFZyV19lobw20tE PtTjDigQKtqMTBc9ohM5ALX15sJXRlwmxZ/VHsI= X-Google-Smtp-Source: APXvYqwa+52T6lEl42UR4l4JCqYs01dXPTl8h5GnRqow8oHgCFNPqL4JOACxrc1HcV1odaRzFYIi256vZzydv0SSYWQ= X-Received: by 2002:a0c:ead1:: with SMTP id y17mr8055946qvp.210.1580443062931; Thu, 30 Jan 2020 19:57:42 -0800 (PST) MIME-Version: 1.0 References: <20200128011817.4095682-1-vijaykhemka@fb.com> In-Reply-To: <20200128011817.4095682-1-vijaykhemka@fb.com> From: Joel Stanley Date: Fri, 31 Jan 2020 03:57:31 +0000 Message-ID: Subject: Re: [PATCH v2] ARM: dts: aspeed: tiogapass: Add gpio line names To: Vijay Khemka Cc: Rob Herring , Mark Rutland , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , Sai Dasari Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jan 2020 at 01:18, Vijay Khemka wrote: > > Added GPIO line names for all gpio used in tiogapass platform, > these line names will be used by libgpiod to control GPIOs > > Signed-off-by: Vijay Khemka The verbosity of the bindings is unfortunate, but I think it's the only option we have to date. Reviewed-by: Joel Stanley I will merge this through the aspeed tree for 5.7. Cheers, Joel > --- > v2 : Added BIOS_SPI_BMC_CTRL gpio line name > > .../dts/aspeed-bmc-facebook-tiogapass.dts | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > index 682f729ea25e..fb7f034d5db2 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > @@ -121,6 +121,69 @@ > kcs_addr = <0xca2>; > }; > > +&gpio { > + status = "okay"; > + gpio-line-names = > + /*A0-A7*/ "BMC_CPLD_FPGA_SEL","","","","","","","", > + /*B0-B7*/ "","BMC_DEBUG_EN","","","","BMC_PPIN","PS_PWROK", > + "IRQ_PVDDQ_GHJ_VRHOT_LVT3", > + /*C0-C7*/ "","","","","","","","", > + /*D0-D7*/ "BIOS_MRC_DEBUG_MSG_DIS","BOARD_REV_ID0","", > + "BOARD_REV_ID1","IRQ_DIMM_SAVE_LVT3","BOARD_REV_ID2", > + "CPU_ERR0_LVT3_BMC","CPU_ERR1_LVT3_BMC", > + /*E0-E7*/ "RESET_BUTTON","RESET_OUT","POWER_BUTTON", > + "POWER_OUT","NMI_BUTTON","","CPU0_PROCHOT_LVT3_ BMC", > + "CPU1_PROCHOT_LVT3_ BMC", > + /*F0-F7*/ "IRQ_PVDDQ_ABC_VRHOT_LVT3","", > + "IRQ_PVCCIN_CPU0_VRHOT_LVC3", > + "IRQ_PVCCIN_CPU1_VRHOT_LVC3", > + "IRQ_PVDDQ_KLM_VRHOT_LVT3","","P3VBAT_BRIDGE_EN","", > + /*G0-G7*/ "CPU_ERR2_LVT3","CPU_CATERR_LVT3","PCH_BMC_THERMTRIP", > + "CPU0_SKTOCC_LVT3","","","","BIOS_SMI_ACTIVE", > + /*H0-H7*/ "LED_POST_CODE_0","LED_POST_CODE_1","LED_POST_CODE_2", > + "LED_POST_CODE_3","LED_POST_CODE_4","LED_POST_CODE_5", > + "LED_POST_CODE_6","LED_POST_CODE_7", > + /*I0-I7*/ "CPU0_FIVR_FAULT_LVT3","CPU1_FIVR_FAULT_LVT3", > + "FORCE_ADR","UV_ADR_TRIGGER_EN","","","","", > + /*J0-J7*/ "","","","","","","","", > + /*K0-K7*/ "","","","","","","","", > + /*L0-L7*/ "IRQ_UV_DETECT","IRQ_OC_DETECT","HSC_TIMER_EXP","", > + "MEM_THERM_EVENT_PCH","PMBUS_ALERT_BUF_EN","","", > + /*M0-M7*/ "CPU0_RC_ERROR","CPU1_RC_ERROR","","OC_DETECT_EN", > + "CPU0_THERMTRIP_LATCH_LVT3", > + "CPU1_THERMTRIP_LATCH_LVT3","","", > + /*N0-N7*/ "","","","CPU_MSMI_LVT3","","BIOS_SPI_BMC_CTRL","","", > + /*O0-O7*/ "","","","","","","","", > + /*P0-P7*/ "BOARD_SKU_ID0","BOARD_SKU_ID1","BOARD_SKU_ID2", > + "BOARD_SKU_ID3","BOARD_SKU_ID4","BMC_PREQ", > + "BMC_PWR_DEBUG","RST_RSMRST", > + /*Q0-Q7*/ "","","","","UARTSW_LSB","UARTSW_MSB", > + "POST_CARD_PRES_BMC","PE_BMC_WAKE", > + /*R0-R7*/ "","","BMC_TCK_MUX_SEL","BMC_PRDY", > + "BMC_XDP_PRSNT_IN","RST_BMC_PLTRST_BUF","SLT_CFG0", > + "SLT_CFG1", > + /*S0-S7*/ "THROTTLE","BMC_READY","","HSC_SMBUS_SWITCH_EN","", > + "","","", > + /*T0-T7*/ "","","","","","","","", > + /*U0-U7*/ "","","","","","BMC_FAULT","","", > + /*V0-V7*/ "","","","FAST_PROCHOT_EN","","","","", > + /*W0-W7*/ "","","","","","","","", > + /*X0-X7*/ "","","","GLOBAL_RST_WARN", > + "CPU0_MEMABC_MEMHOT_LVT3_BMC", > + "CPU0_MEMDEF_MEMHOT_LVT3_BMC", > + "CPU1_MEMGHJ_MEMHOT_LVT3_BMC", > + "CPU1_MEMKLM_MEMHOT_LVT3_BMC", > + /*Y0-Y7*/ "SIO_S3","SIO_S5","BMC_JTAG_SEL","SIO_ONCONTROL","", > + "","","", > + /*Z0-Z7*/ "","SIO_POWER_GOOD","IRQ_PVDDQ_DEF_VRHOT_LVT3","", > + "","","","", > + /*AA0-AA7*/ "CPU1_SKTOCC_LVT3","IRQ_SML1_PMBUS_ALERT", > + "SERVER_POWER_LED","","PECI_MUX_SELECT","UV_HIGH_SET", > + "","POST_COMPLETE", > + /*AB0-AB7*/ "IRQ_HSC_FAULT","OCP_MEZZA_PRES","","","","","","", > + /*AC0-AC7*/ "","","","","","","",""; > +}; > + > &mac0 { > status = "okay"; > > -- > 2.17.1 >