From: Joel Stanley <joel@jms.id.au>
To: George Liu <liuxiwei1013@gmail.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
George Liu <liuxiwei@inspur.com>
Subject: Re: [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding
Date: Tue, 14 Sep 2021 08:45:13 +0000 [thread overview]
Message-ID: <CACPK8XfbJbU8zPzTri3o+zbSf82iUuGUXmFL5TwsdPHKLnTNTQ@mail.gmail.com> (raw)
In-Reply-To: <CANFuQ7A5jLXftmfLn_W93MuDF8heL88BPQRL_rkYk+bj0_Db0w@mail.gmail.com>
On Tue, 14 Sept 2021 at 08:16, George Liu <liuxiwei1013@gmail.com> wrote:
>
> Hey Joel:
> do you have any comments at this patch?
>
> Thx -- George Liu
>
> On Thu, Aug 19, 2021 at 1:52 PM George Liu <liuxiwei1013@gmail.com> wrote:
> >
> > Signed-off-by: George Liu <liuxiwei@inspur.com>
It looks okay to me.
Reviewed-by: Joel Stanley <joel@jms.id.au>
I have applied it for 5.16.
> > ---
> > arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > index 1752f3250e44..d0c3acbf6c8c 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts
> > @@ -3,6 +3,7 @@
> > #include "aspeed-g5.dtsi"
> > #include <dt-bindings/gpio/aspeed-gpio.h>
> > #include <dt-bindings/leds/leds-pca955x.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> >
> > / {
> > model = "FP5280G2 BMC";
> > @@ -902,4 +903,10 @@ fan@7 {
> >
> > };
> >
> > +&kcs3 {
> > + status = "okay";
> > + aspeed,lpc-io-reg = <0xca2>;
> > + aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> > +};
> > +
> > #include "ibm-power9-dual.dtsi"
> > --
> > 2.30.2
> >
next prev parent reply other threads:[~2021-09-14 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 5:52 [PATCH] ARM: dts: fp5280g2: Enable KCS 3 for MCTP binding George Liu
2021-09-14 8:15 ` George Liu
2021-09-14 8:45 ` Joel Stanley [this message]
2021-09-14 8:55 ` George Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XfbJbU8zPzTri3o+zbSf82iUuGUXmFL5TwsdPHKLnTNTQ@mail.gmail.com \
--to=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxiwei1013@gmail.com \
--cc=liuxiwei@inspur.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).