From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Nick Dyer <nick@shmanahar.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jiada Wang <jiada_wang@mentor.com>,
Linux Input <linux-input@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: input: atmel_mxt_ts: Document atmel,wakeup-method and wake-GPIO
Date: Sun, 6 Dec 2020 16:13:59 +0100 [thread overview]
Message-ID: <CACRpkdY+fLhUD4cpM7X96Z7XjtXBkoVDRN6pDBUk+PjrQjTxcA@mail.gmail.com> (raw)
In-Reply-To: <20201205053328.9535-2-digetx@gmail.com>
On Sat, Dec 5, 2020 at 6:34 AM Dmitry Osipenko <digetx@gmail.com> wrote:
> Some Atmel touchscreen controllers have a WAKE line that needs to be
> asserted low in order to wake up controller from a deep sleep. Document
> the wakeup methods and the wake-GPIO properties.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Looks really useful!
> + atmel,wakeup-method:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + The WAKE line is an active-low input that is used to wake up the touch
> + controller from deep-sleep mode before communication with the controller
> + could be started. This feature used to minimize current consumption
> + when the controller is in deep sleep mode.
> +
> + The WAKE pin can be connected in one of the following ways:
> + 1) left permanently low
> + 2) connected to the I2C-compatible SCL pin
> + 3) connected to a GPIO pin on the host
> + enum:
> + - 0 # ATMEL_MXT_WAKEUP_NONE
> + - 1 # ATMEL_MXT_WAKEUP_I2C_SCL
> + - 2 # ATMEL_MXT_WAKEUP_GPIO
So you can add:
minimum: 0
maximum: 2
I suppose?
With that:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-12-06 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 5:33 [PATCH v1 0/3] Support wakeup methods of Atmel maXTouch controllers Dmitry Osipenko
2020-12-05 5:33 ` [PATCH v1 1/3] dt-bindings: input: atmel_mxt_ts: Document atmel,wakeup-method and wake-GPIO Dmitry Osipenko
2020-12-06 15:13 ` Linus Walleij [this message]
2020-12-06 19:41 ` Dmitry Osipenko
2020-12-05 5:33 ` [PATCH v1 2/3] Input: atmel_mxt_ts - support wakeup methods Dmitry Osipenko
2020-12-05 5:41 ` Dmitry Osipenko
2020-12-05 5:33 ` [PATCH v1 3/3] ARM: tegra: acer-a500: Add atmel,wakeup-method property Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY+fLhUD4cpM7X96Z7XjtXBkoVDRN6pDBUk+PjrQjTxcA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jiada_wang@mentor.com \
--cc=jonathanh@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).