LKML Archive on
 help / color / Atom feed
From: Linus Walleij <>
To: Nathan Chancellor <>,
	Laxman Dewangan <>
Cc: "open list:GPIO SUBSYSTEM" <>,
	"" <>,
	Nick Desaulniers <>
Subject: Re: [PATCH] pinctrl: max77620: Use define directive for max77620_pinconf_param values
Date: Fri, 9 Nov 2018 10:01:53 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Nov 1, 2018 at 1:51 AM Nathan Chancellor
<> wrote:

> Clang warns when one enumerated type is implicitly converted to another:
> drivers/pinctrl/pinctrl-max77620.c:56:12: warning: implicit conversion
> from enumeration type 'enum max77620_pinconf_param' to different
> enumeration type 'enum pin_config_param' [-Wenum-conversion]
>                 .param = MAX77620_ACTIVE_FPS_SOURCE,
>                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> It is expected that pinctrl drivers can extend pin_config_param because
> of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion
> isn't an issue. Most drivers that take advantage of this define the
> PIN_CONFIG variables as constants, rather than enumerated values. Do the
> same thing here so that Clang no longer warns.
> Link:
> Signed-off-by: Nathan Chancellor <>

Patch tentatively applied.

This seems to be the direction we need to be going with a lot
of CLANG business.

Laxman: you weren't CCed, so tell us if you dislike it for some

Linus Walleij

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01  0:50 Nathan Chancellor
2018-11-09  9:01 ` Linus Walleij [this message]
2018-11-09 10:48   ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone