From: Linus Walleij <linus.walleij@linaro.org>
To: shiraz hashim <shiraz.linux.kernel@gmail.com>
Cc: Roland Stigge <stigge@antcom.de>,
aletes.xgr@gmail.com, broonie@opensource.wolfsonmicro.com,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
gabriel.fernandez@stericsson.com, lee.jones@linaro.org,
viresh.kumar@linaro.org, sachin.verma@st.co
Subject: Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO
Date: Sun, 2 Sep 2012 09:18:29 +0200 [thread overview]
Message-ID: <CACRpkdY3atmx4N-Zq2imrgPoukueYiexzndD7bVyQTgV02Vpuw@mail.gmail.com> (raw)
In-Reply-To: <CAPub14-Oot_wJsRTv2AGu3SAAf40+3_wK43=0Swxj+5XjPaDew@mail.gmail.com>
On Sat, Sep 1, 2012 at 1:14 PM, shiraz hashim
<shiraz.linux.kernel@gmail.com> wrote:
> Hi Roland,
>
> On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge <stigge@antcom.de> wrote:
>> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co
>> pl022->master_info = platform_info;
>> pl022->adev = adev;
>> pl022->vendor = id->data;
>> + /* Point chipselects to allocated memory beyond the main struct */
>> + pl022->chipselects = (int *) pl022 + sizeof(struct pl022);
>
> This is going beyond memory allocated for chipselects
> as it adds 4 * sizeof(struct pl022) bytes to pl022.
Yes that is why the allocation looks like this:
+ master = spi_alloc_master(dev, sizeof(struct pl022) + sizeof(int) *
+ platform_info->num_chipselect);
> pl022->chipselects = (int *) &pl022[1];
> can be musch safer.
I see absolutely no sematic difference between these two
methods to reach the first position beyond the first struct.
If we're gonna be debating this it's a safe sign that this is
not a good design pattern at all, so then it is better to simply
devm_kzalloc(sizeof(int) * platform_info->num_chipselect);
separately.
(But I'm happy with the patch as it is. And the other way
too, since I'm not very picky.)
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-09-02 7:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 13:49 [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO Roland Stigge
2012-08-22 13:49 ` [PATCH v6 2/3] spi/pl022: Add devicetree support Roland Stigge
2012-08-22 18:38 ` Linus Walleij
2012-08-22 13:49 ` [PATCH v6 3/3] DT bindings documentation: "num-cs" property for SPI controllers Roland Stigge
2012-08-22 18:39 ` Linus Walleij
2012-08-22 19:03 ` Mark Brown
2012-08-22 18:37 ` [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO Linus Walleij
2012-09-01 11:14 ` shiraz hashim
2012-09-02 7:18 ` Linus Walleij [this message]
2012-09-02 13:12 ` shiraz hashim
2012-09-03 9:10 ` Linus Walleij
2012-09-02 20:04 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY3atmx4N-Zq2imrgPoukueYiexzndD7bVyQTgV02Vpuw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=aletes.xgr@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gabriel.fernandez@stericsson.com \
--cc=grant.likely@secretlab.ca \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sachin.verma@st.co \
--cc=shiraz.linux.kernel@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=stigge@antcom.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).