From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4278C4338F for ; Wed, 11 Aug 2021 08:25:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD8BA60F55 for ; Wed, 11 Aug 2021 08:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236044AbhHKIZk (ORCPT ); Wed, 11 Aug 2021 04:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233112AbhHKIZi (ORCPT ); Wed, 11 Aug 2021 04:25:38 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 124D8C061765 for ; Wed, 11 Aug 2021 01:25:15 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id h9so3237929ljq.8 for ; Wed, 11 Aug 2021 01:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zYG5OW/GuymVifdul+I5Blg04g1AAAuKaCzk0pvxhf0=; b=JkV7+VuBX5K8gla+CwLaHXvUhgX/3/dJKO5GvH3X+2fpHvc1tFi1HU1F0ziyTvpwf5 QPM7g2HMUSED4KzVS/g/93Duae/vBTVp6NehMfjyCW1VA7AgjotRGjj+qxQylG2s3Wbf bPWzUwSX19VB0o394R2/B8eURFP2w3Yto/QB+Pug9yFjCGd5zwjlVbQOv2vGk6hv744V 83I0NxCVq5gx8hG4Jy+sBpnSxOo0BYgeYXD5sFnWakt0/dbE3woTztU3g1TZhQ/dTac7 zoGO6i3JdC/phPsXewy/Io6GaXQe+zOnBKcvcziyK/tt3l0HaMe6NA1qa+ZEOJHJmliP gDew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zYG5OW/GuymVifdul+I5Blg04g1AAAuKaCzk0pvxhf0=; b=Pf8rVLeLbwk1TI8BJDk5wCLZDVYMReheWVSUopZJNs/1AX9S4T/vWqpw5TSUVDifcn m+KKLL/6dtMDX+n4IGaZ7yAGQ0sZJx7aI/HplzX/fkL/vcQ8EUXsjB8tCbU7AdXp8AX1 +a2rmfc3hfobo86q140tVNd7xIRlhwZC9/fyPIVfPoSsrrc2FZ1fNLambCmqRBAtMScH KyzILsqGlkrthejffru/laDrwMnp+gi+oXD0iO/R9h1CSZehF+vA0sGSq9R+0jITpf// TQWbfaoxKii2P4zEkF2skbHuO5GjdUZIjm25gUTpZburPfQ7mzDG74mAZCO/AXydo6OF EfFA== X-Gm-Message-State: AOAM5316ebItUSj+iJ9KdoDPvPGzoQO2iZTgwOKo5utZxvR4aNYoP7g/ NW1t/lBHO/gTXvLG1xqvV0KzoHnHL8LhZhsejHSysw== X-Google-Smtp-Source: ABdhPJyCWvmoleKs+xBVZZ6DUMgjMXPl0OJ3a6DQFu9ePBD1OEIdGRr9JPO3iNfDJuIooutbqNKEx3Horr68DKpJ8SY= X-Received: by 2002:a2e:9a4b:: with SMTP id k11mr11984502ljj.368.1628670313474; Wed, 11 Aug 2021 01:25:13 -0700 (PDT) MIME-Version: 1.0 References: <20210717174836.14776-1-paul@crapouillou.net> <20210717174836.14776-2-paul@crapouillou.net> In-Reply-To: <20210717174836.14776-2-paul@crapouillou.net> From: Linus Walleij Date: Wed, 11 Aug 2021 10:25:02 +0200 Message-ID: Subject: Re: [PATCH 2/3] pinctrl: ingenic: Fix bias config for X2000(E) To: Paul Cercueil Cc: =?UTF-8?B?5ZGo55Cw5p2w?= , linux-mips@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-kernel , stable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 7:48 PM Paul Cercueil wrote: > The ingenic_set_bias() function's "bias" argument is not a > "enum pin_config_param", so its value should not be compared against > values of that enum. > > This should fix the bias config not working on the X2000(E) SoCs. > > Fixes: 943e0da15370 ("pinctrl: Ingenic: Add pinctrl driver for X2000.") > Cc: # v5.12 > Signed-off-by: Paul Cercueil Patch applied! Yours, Linus Walleij