From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD552C433B4 for ; Thu, 6 May 2021 10:26:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CBBA61059 for ; Thu, 6 May 2021 10:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234398AbhEFK1o (ORCPT ); Thu, 6 May 2021 06:27:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbhEFK1n (ORCPT ); Thu, 6 May 2021 06:27:43 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE06BC06174A for ; Thu, 6 May 2021 03:26:44 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id v5so6364196ljg.12 for ; Thu, 06 May 2021 03:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q7Lt8jBe6wv03L7Ev9R6s3zonVps5OT2POfrWhLS1O0=; b=NFJsPlS4lkvyLn3LRx72UHEDMNshTOZzxwz0yMZzQM6RudpaF5F5pOomw4noNlH8dy reociugEQom2ZHSOMYToiAPYZdzIJO/p8iL9V5JcvEJH9qsqf/wq7jrSTNKNIMD3T7Ld Uf6ZntZVT3+DdZ4u5NHcPdG/4UmvQWRE12E5GxaYNuVob8DwmjsDnbyrGsa69KccIcKT WWJ6pFdJtiJjnqHni4xcUxmZ4pQnJPX4UvBwrFvh5npNzgcNKa2lnh+DgpP/1S9x3EdP vinGZfVu/Dm2a6PBStO/6vI4c4a8O7ijr0qWEy65WJnaGUpeYh0oue0/LPAUxPNS70pA egFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q7Lt8jBe6wv03L7Ev9R6s3zonVps5OT2POfrWhLS1O0=; b=KsySmZ8WdMaSbCQeJCfmz2mCKSiz9QpvOcD8O3QyklZ5Xwr0gdC+VgCDovd5jA7xYX WMuw/yWg0TYK8rVEjdJVYoM+3juq7E/hr+4Bc9J+85qU5ed/SQuwEBtYhZWGjwT4BN6b /ZZ8Mpb+mSqWaAyhhTafQH/crAAP4uuyCOfsH1M87kaptlXzsJr1zkjXUZYzOUkaNkvk 3ezaWK+/47p/NGJT08dBLV1ymPNgIzVE3dFHmBwA50sJ9/9mrmIwlp0tkjIzhCVjd8HQ 7N2Ed1hW6TtHPJNaNWL+E5au7IUImL2kCExwrTbNO3ynCSfUKHkehwUy5UvEo2x+RlC0 BIWQ== X-Gm-Message-State: AOAM531+avcOHcTH3VrkgUNQn9w2T2f0NURBndgncJh3ocw6thAATwkj TzdO3b6rQiHiP4IhpF1bjHaejPxXA+0ZY+MS5RyggA== X-Google-Smtp-Source: ABdhPJxci8zA6ho0aB6xDVxMD+TN9K2noCf9jKls117BIuDpVHkP+exwEZFomfQiAE5eaq4sUwzXLRUcJth0e2ZqDP8= X-Received: by 2002:a2e:81d0:: with SMTP id s16mr2938854ljg.74.1620296803490; Thu, 06 May 2021 03:26:43 -0700 (PDT) MIME-Version: 1.0 References: <20210428175503.3692090-1-clabbe@baylibre.com> In-Reply-To: <20210428175503.3692090-1-clabbe@baylibre.com> From: Linus Walleij Date: Thu, 6 May 2021 12:26:32 +0200 Message-ID: Subject: Re: [PATCH] ARM: dts: gemini: rename to nand-controller To: Corentin Labbe Cc: Rob Herring , Hans Ulli Kroll , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 28, 2021 at 7:55 PM Corentin Labbe wrote: > We must use nand-controller instead of flash. > > Signed-off-by: Corentin Labbe Hm, this flash memory isn't NAND, it is just memory-mapped NOR flash. The example for CFI NOR flash in Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml clearly uses the node name "flash@" There is however a real NAND and serial flash memory controller at 0x65000000, but I haven't seen a platform that uses it. The extra compatible string "cortina,gemini-flash" turns on some Gemini-specific checks, but it goes into the global system controller, not the NAND controller, as the system controller confusingly have some registers for detecting NOR memory config. drivers/mtd/maps/physmap-gemini.c Yours, Linus Walleij