From: Linus Walleij <linus.walleij@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Tal Shorer <tal.shorer@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [Patch v3 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events
Date: Sat, 6 Apr 2019 00:25:19 +0700 [thread overview]
Message-ID: <CACRpkdY62aXDOZm7cK4ND-RSnr9Ynz0DxS8-PHSF7i7diRG=WA@mail.gmail.com> (raw)
In-Reply-To: <20190327161158.GA26067@taurus.defre.kleine-koenig.org>
On Wed, Mar 27, 2019 at 11:12 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> It happened a few times to me since this patch was merged (in 4.4-rc1)
> that I worked on a system with tracing enabled but
> /sys/kernel/debug/tracing/events/gpio were missing because of
> CONFIG_TRACING_EVENTS_GPIO=n. This is annoying and I wonder what is the
> motivating purpose of allowing to disable gpio events. There is no other
> event type that can be disabled with kconfig symbols. Theoretically the
> overhead should be so small, that having these events enabled
> unconditionally should be fine, shouldn't it?
You have a good point. We should not do anything special.
I guess by the time this was merged I believed it was customary
for trancepoints to live behind a Kconfig option.
I guess it is not.
I happily merge a patch removing this again if no case
can be made for it.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-04-05 17:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 20:21 [Patch RFC 0/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-06-20 20:21 ` [Patch RFC 1/2] " Tal Shorer
2015-07-13 18:34 ` Steven Rostedt
2015-07-13 21:38 ` Tal Shorer
2015-07-16 17:39 ` [PATCH v2 0/2] " Tal Shorer
2015-07-16 17:39 ` [PATCH v2 1/2] " Tal Shorer
2015-07-16 17:39 ` [PATCH v2 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Tal Shorer
2015-07-17 18:36 ` Steven Rostedt
2015-07-18 10:12 ` Tal Shorer
2015-08-01 12:27 ` [Patch v3 0/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-08-01 12:27 ` [Patch v3 1/2] " Tal Shorer
2015-08-01 12:27 ` [Patch v3 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Tal Shorer
2015-08-11 19:45 ` Tal Shorer
2015-09-23 14:54 ` Tal Shorer
2019-03-27 16:12 ` Uwe Kleine-König
2019-04-05 17:25 ` Linus Walleij [this message]
2015-07-27 11:57 ` [PATCH v2 " Linus Walleij
2015-06-20 20:21 ` [Patch RFC " Tal Shorer
2015-06-25 20:41 ` [Patch RFC 0/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-06-25 22:25 ` Steven Rostedt
2015-07-06 16:53 ` Tal Shorer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY62aXDOZm7cK4ND-RSnr9Ynz0DxS8-PHSF7i7diRG=WA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tal.shorer@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).