From: Linus Walleij <linus.walleij@linaro.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Tomer Maimon <tmaimon77@gmail.com>, Joel Stanley <joel@jms.id.au>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/8] dt-bindings: pinctrl: Add Nuvoton WPCM450
Date: Fri, 4 Jun 2021 11:35:48 +0200 [thread overview]
Message-ID: <CACRpkdY6c750Dnh2H_6uEhOHJv-kLd_OpHqnuDKu4DQezZ2C_w@mail.gmail.com> (raw)
In-Reply-To: <20210602120329.2444672-5-j.neuschaefer@gmx.net>
Hi Jonathan!
thanks for your patch!
On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> + interrupts: true
maxitems 4 right?
Make an enum:
interrupts:
- description: what IRQ0 is for
- description: what IRQ1 is for
- description: what IRQ2 is for
- description: what IRQ3 is for
And describe how these interrupts are used. Because I am suspicious that they
actually correspond to 4 different GPIO blocks, which should then be their own
nodes.
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/gpio/gpio.h>
> + pinctrl: pinctrl@b8003000 {
> + compatible = "nuvoton,wpcm450-pinctrl";
> + reg = <0xb8003000 0x1000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH
> + 3 IRQ_TYPE_LEVEL_HIGH
> + 4 IRQ_TYPE_LEVEL_HIGH
> + 5 IRQ_TYPE_LEVEL_HIGH>;
So these.
> + rmii2 {
> + groups = "rmii2";
> + function = "rmii2";
> + };
> +
> + pinctrl_uid: uid {
> + pins = "gpio14";
> + input-debounce = <1>;
> + };
I challenge you here and encourage you to put a node for each
GPIO "port":
port0: gpio@0 {
....
};
port1: gpio@1 {
....
};
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uid>;
> +
> + uid {
> + label = "UID";
> + linux,code = <102>;
> + gpios = <&pinctrl 14 GPIO_ACTIVE_HIGH>;
Would be gpios <&port0 14...>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-06-04 9:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 12:03 [PATCH 0/8] Nuvoton WPCM450 pinctrl and GPIO driver Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR) Jonathan Neuschäfer
2021-06-04 8:00 ` Linus Walleij
2021-06-13 9:20 ` Jonathan Neuschäfer
2021-06-15 23:43 ` Rob Herring
2021-06-19 10:08 ` Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 2/8] MAINTAINERS: Match all of bindings/arm/npcm/ as part of NPCM architecture Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 3/8] ARM: dts: wpcm450: Add global control registers (GCR) node Jonathan Neuschäfer
2021-06-04 8:01 ` Linus Walleij
2021-06-13 9:23 ` Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 4/8] dt-bindings: pinctrl: Add Nuvoton WPCM450 Jonathan Neuschäfer
2021-06-04 9:35 ` Linus Walleij [this message]
2021-06-13 9:53 ` Jonathan Neuschäfer
2021-06-15 23:45 ` Rob Herring
2021-06-19 10:17 ` Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 5/8] pinctrl: nuvoton: Add driver for WPCM450 Jonathan Neuschäfer
2021-06-02 12:50 ` Andy Shevchenko
2021-06-12 23:20 ` Jonathan Neuschäfer
2021-06-13 10:06 ` Andy Shevchenko
2021-06-13 19:08 ` Jonathan Neuschäfer
2021-06-02 14:31 ` kernel test robot
2021-06-03 18:33 ` kernel test robot
2021-06-04 9:31 ` Linus Walleij
2021-06-13 10:26 ` Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 6/8] ARM: dts: wpcm450: Add pinctrl node Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 7/8] ARM: dts: wpcm450: Add pin functions Jonathan Neuschäfer
2021-06-02 12:03 ` [PATCH 8/8] ARM: dts: wpcm450-supermicro-x9sci-ln4f: Add GPIO LEDs and buttons Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY6c750Dnh2H_6uEhOHJv-kLd_OpHqnuDKu4DQezZ2C_w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).