From: Linus Walleij <email@example.com>
Cc: Rajat Jain <firstname.lastname@example.org>,
Andy Shevchenko <email@example.com>,
Mika Westerberg <firstname.lastname@example.org>,
Andy Shevchenko <email@example.com>,
Dmitry Torokhov <firstname.lastname@example.org>,
"open list:GPIO SUBSYSTEM" <email@example.com>,
ACPI Devel Maling List <firstname.lastname@example.org>,
Adrian Hunter <email@example.com>,
Ulf Hansson <firstname.lastname@example.org>,
Subject: Re: sdhci driver card-detect is broken because gpiolib can't fallback to _CRS?
Date: Fri, 28 Sep 2018 15:13:31 +0200 [thread overview]
Message-ID: <CACRpkdY7eaYk81CU8gmHKfWB82_qNJur=c=7SCRuW+BNeL=Oiw@mail.gmail.com> (raw)
On Fri, Sep 28, 2018 at 2:34 PM Rajat Jain <email@example.com> wrote:
> > This is not looking good at all.
> > Andy should we revert the patch or do you have some other
> > quick fix in mind we could do? It seems reverting the patch
> > could be bad for the mctrl patches IIUC, but this regression
> > seems even more serious.
> Sorry, I may have made it sound like more serious than it is. Yes,
> what I said is true, but we (Google) does not plan to update those
> devices to the latest kernel. That regression will only be seen by any
> developers who try to do it on their own.
Given the number of core kernel developers using chromebooks
and relying on them to be working as expected, these are the
users I am most worried about, really.
If only 3 users in the world can't read photos from their SD-cards
that may sound like a small problem, but if those 3 users are
core kernel developers reporting bugs, I as maintainer have a
big problem. So not all users are equal, or how should I put it.
> Also, the commit I mentioned above was put in long time back, and I
> think it is more reasonable to put a fix in the sdhci driver instead.
> - It seems that 1 SDHCI device may support multiple slots. It was not
> clear to me if they could share card detect interrupts, or should have
> separate ones? Also, the driver may not really know? So should I add 1
> or two pins using the devm_acpi_dev_add_driver_gpios().
> - I was unsure what should I set the active_low to.
> Given these concerns, it seemed the easiest fix to me, if we can call
> mmc_gpiod_request_cd() twice, once with "cd" and then with NULL as a
That sounds like a resonable fix to me.
next prev parent reply other threads:[~2018-09-28 13:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 20:54 sdhci driver card-detect is broken because gpiolib can't fallback to _CRS? Rajat Jain
2018-09-26 7:47 ` Mika Westerberg
2018-09-26 8:42 ` Andy Shevchenko
2018-09-26 19:25 ` Rajat Jain
2018-09-27 7:26 ` Andy Shevchenko
2018-09-27 17:56 ` Rajat Jain
2018-09-28 8:42 ` Linus Walleij
2018-09-28 12:34 ` Rajat Jain
2018-09-28 13:13 ` Linus Walleij [this message]
2018-10-18 21:51 ` [PATCH] mmc: sdhci-pci: Try "cd" for card-detect lookup before using NULL Rajat Jain
2018-10-19 9:13 ` Andy Shevchenko
2018-10-22 23:34 ` Rajat Jain
2018-10-24 10:02 ` Andy Shevchenko
2018-10-24 18:03 ` Dmitry Torokhov
2018-10-29 15:23 ` Andy Shevchenko
2018-10-29 17:22 ` Rajat Jain
2018-10-29 17:43 ` Andy Shevchenko
2018-10-29 19:43 ` Rajat Jain
2018-10-29 22:17 ` [PATCH v2] " Rajat Jain
2018-10-30 7:53 ` Adrian Hunter
2018-11-12 11:05 ` Ulf Hansson
2018-11-12 11:25 ` Andy Shevchenko
2018-11-13 1:26 ` Rajat Jain
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).