From: Linus Walleij <linus.walleij@linaro.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Peter Rosin <peda@axentia.se>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Roland Stigge <stigge@antcom.de>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Subject: Re: [PATCH v3] pinctrl: Add SX150X GPIO Extender Pinctrl Driver
Date: Mon, 24 Oct 2016 16:39:17 +0200 [thread overview]
Message-ID: <CACRpkdY7vLU4yVP7M-O4rGt_L5cqL57ApmMQJ4aRGgzh3Nat6Q@mail.gmail.com> (raw)
In-Reply-To: <CAHQ1cqGLQ=DdhXg1ebkgBbLN8P2P8BEDrGGTx9_r+6=Wy3uUWA@mail.gmail.com>
On Mon, Oct 24, 2016 at 6:51 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> It seem strange to me that the driver uses "handle_edge_irq", given
> how none of the individual interrupts seem to require any ACKing,
> since it is all handled in sx150x_irq_thread_fn(), line 533. More so,
> I had trouble finding who/where sets .irq_ack() callback, which AFAIU
> is mandatory for handle_edge_irq().
Yes that looks strange.
Neil have you tested IRQs with this code?
If there is trouble, please follow up with a fix for the edge handler.
Maybe it should just be handle_simple_irq().
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-10-24 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 9:09 [PATCH v3] pinctrl: Add SX150X GPIO Extender Pinctrl Driver Neil Armstrong
2016-10-21 9:19 ` Neil Armstrong
2016-10-23 2:50 ` Andrey Smirnov
2016-10-23 10:47 ` Linus Walleij
2016-10-24 4:51 ` Andrey Smirnov
2016-10-24 14:39 ` Linus Walleij [this message]
2016-10-25 6:57 ` Neil Armstrong
2016-10-23 10:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY7vLU4yVP7M-O4rGt_L5cqL57ApmMQJ4aRGgzh3Nat6Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=peda@axentia.se \
--cc=stigge@antcom.de \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).