From: Linus Walleij <linus.walleij@linaro.org>
To: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Pramod Kumar <pramodku@broadcom.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH RESEND 1/2] pinctrl: ns2: add pinmux driver support for Broadcom NS2 SoC
Date: Wed, 13 Apr 2016 15:19:01 +0200 [thread overview]
Message-ID: <CACRpkdY8R91_j4+A_CFzrZdp1zj10SBthL2yyoSxUDJnVBs8NA@mail.gmail.com> (raw)
In-Reply-To: <1459264932-27884-2-git-send-email-yendapally.reddy@broadcom.com>
On Tue, Mar 29, 2016 at 5:22 PM, Yendapally Reddy Dhananjaya Reddy
<yendapally.reddy@broadcom.com> wrote:
> This adds the initial support of the Broadcom NS2 pinmux driver
>
> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Sorry for slow replies. :(
This mostly looks good. Some small things needs fixing:
> +config PINCTRL_NS2_MUX
> + bool "Broadcom Northstar2 pinmux driver"
This is a bool driver, yet it uses MODULE* macros at the end of the file.
Check the recent commits from Paul Gortmaker cleaning this up.
Just a git log -p --author=Gortmaker in the main kernel tree will quickly
give you an idea of what you have to do.
> +static const unsigned int gpio_0_1_pins[] = {24, 25};
> +static const unsigned int pwm_0_pins[] = {24};
> +static const unsigned int pwm_1_pins[] = {25};
So either the same pins are used for GPIO or PWM.
And this pattern persists.
Do you have a brewing GPIO driver for this block as well?
Is it a separate front-end calling to pinctrl using the
pinctrl_gpio_* calls or do you plan to patch it into this
driver?
This is more of a question.
Apart from this it looks good.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-04-13 13:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 15:22 [PATCH RESEND 0/2] pinmux support for Broadcom NS2 SoC Yendapally Reddy Dhananjaya Reddy
2016-03-29 15:22 ` [PATCH RESEND 1/2] pinctrl: ns2: add pinmux driver " Yendapally Reddy Dhananjaya Reddy
2016-04-13 13:19 ` Linus Walleij [this message]
2016-03-29 15:22 ` [PATCH RESEND 2/2] ARM: dts: enable pinctrl " Yendapally Reddy Dhananjaya Reddy
2016-04-13 13:24 ` Linus Walleij
2016-04-14 7:53 [PATCH RESEND 1/2] pinctrl: ns2: add pinmux driver support " Yendapally Reddy Dhananjaya Reddy
2016-04-14 9:42 ` Linus Walleij
2016-04-18 3:34 Yendapally Reddy Dhananjaya Reddy
2016-04-18 18:24 ` Ray Jui
2016-04-29 8:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY8R91_j4+A_CFzrZdp1zj10SBthL2yyoSxUDJnVBs8NA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=pramodku@broadcom.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
--cc=yendapally.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).