From: Linus Walleij <linus.walleij@linaro.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors
Date: Mon, 7 Aug 2023 22:45:00 +0200 [thread overview]
Message-ID: <CACRpkdY8cH3pAcQZCEOV=QN+iAE6hBoD+3ZJ2C4VGD0R5FP2Jg@mail.gmail.com> (raw)
In-Reply-To: <87eada13-004a-4dd1-91fe-901cfdfd7992@amd.com>
On Mon, Aug 7, 2023 at 8:17 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
> On 7/23/2023 14:41, Linus Walleij wrote:
> > On Mon, Jul 17, 2023 at 10:17 PM Mario Limonciello
> > <mario.limonciello@amd.com> wrote:
> >
> >> On some systems amd_pinconf_set() is called with parameters
> >> 0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
> >> which are not supported by pinctrl-amd.
> >>
> >> Don't show an err message when called with an invalid parameter,
> >> downgrade this to debug instead.
> >>
> >> Cc: stable@vger.kernel.org # 6.1
> >> Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> > Applied for nonurgent fixes.
> >
>
> Just wanted to check if you'll be sending this out for -rc6. It
> backported to stable and a few bugs cropped up because it's noisy.
No, nonurgent means I queue it for v6.6. Fear of causing regressions
on mainline is the reason to not send fixes unless they are urgent.
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-08-07 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 20:16 [PATCH] pinctrl: amd: Don't show `Invalid config param` errors Mario Limonciello
2023-07-23 19:41 ` Linus Walleij
2023-08-07 18:17 ` Mario Limonciello
2023-08-07 20:45 ` Linus Walleij [this message]
2023-08-07 20:47 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY8cH3pAcQZCEOV=QN+iAE6hBoD+3ZJ2C4VGD0R5FP2Jg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).