From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1426016AbeCBJxL (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Mar 2018 04:53:11 -0500
Received: from mail-it0-f67.google.com ([209.85.214.67]:35747 "EHLO
        mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1424687AbeCBJxC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Mar 2018 04:53:02 -0500
X-Google-Smtp-Source: AG47ELtEiEzGAQ+k877liTNHu59JU2CYdgINhcO7TS2PekP0gapVAOJHjk1YgXRpbxQYODvfKymJYNYbYMMxoI8d+2U=
MIME-Version: 1.0
In-Reply-To: <2e9852f21fcc6213bdb1cef0c473b9d002ad5670.1519468782.git.baolin.wang@linaro.org>
References: <334505d3a13a73ad347427b408ed581832434289.1519468782.git.baolin.wang@linaro.org>
 <2e9852f21fcc6213bdb1cef0c473b9d002ad5670.1519468782.git.baolin.wang@linaro.org>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Fri, 2 Mar 2018 10:53:00 +0100
Message-ID: <CACRpkdY8hcNYASBFJewVfpiukT+AAR-5WZb0uaJws0B025+GJw@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] gpio: Add Spreadtrum EIC driver support
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
        <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 24, 2018 at 11:44 AM, Baolin Wang <baolin.wang@linaro.org> wrote:

> The Spreadtrum digital-chip EIC controller has 4 sub-modules: debounce EIC,
> latch EIC, async EIC and sync EIC, and each sub-module can has multiple
> banks and each bank contains 8 EICs.
>
> Each EIC can only be used as input mode, and has the capability to trigger
> interrupts when detecting input signals.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> Changes since v1:
>  - Add OF_GPIO dependency.
>  - Fix some typos and grammar issues.
>  - Simplify the sprd_eic_update() and sprd_eic_read().
>  - Rename 'sprd_eic_data' to 'sprd_eic_variant_data'.
>  - Rename sprd_eic_group_base() to sprd_eic_offset_base().
>  - Split the PMIC EIC support into one separate driver.
>  - Return -EIO for sprd_eic_direction_input().
>  - Other optimization.

This is looking nice!

I guess we agreed with the input maintainer that what
needs to happen is to implement edge trigger emulation
for all variants in the driver, test it with the keys and
then we should be done.

Yours,
Linus Walleij