From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936765Ab3DJUye (ORCPT ); Wed, 10 Apr 2013 16:54:34 -0400 Received: from mail-ia0-f174.google.com ([209.85.210.174]:37520 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935970Ab3DJUyd (ORCPT ); Wed, 10 Apr 2013 16:54:33 -0400 MIME-Version: 1.0 In-Reply-To: <1365010814-3263-1-git-send-email-alexandre.belloni@free-electrons.com> References: <1365010814-3263-1-git-send-email-alexandre.belloni@free-electrons.com> Date: Wed, 10 Apr 2013 22:54:31 +0200 Message-ID: Subject: Re: [PATCH] gpio: pca953x: fix irq_domain_add_simple usage From: Linus Walleij To: Alexandre Belloni Cc: Grant Likely , jimwall@q.com, brian@crystalfontz.com, Maxime Ripard , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 3, 2013 at 7:40 PM, Alexandre Belloni wrote: > We actually have to pass chip as the host_data parameter of > irq_domain_add_simple() as later on, it is used to initialize chip_data > in pca953x_gpio_irq_map(). Failing to do so is leading to a NULL pointer > dereference after calling irq_data_get_irq_chip_data() in > pca953x_irq_mask(), pca953x_irq_unmask(), pca953x_irq_bus_lock(), > pca953x_irq_bus_sync_unlock() and pca953x_irq_set_type(). > > Fixes regression introduced by commit > 0e8f2fdacf1d44651aa7e57063c76142d1f4988b (gpio: pca953x: use simple > irqdomain) > > Signed-off-by: Alexandre Belloni > --- > > This would probably be good to introduce that patch in the next 3.9 rc as the > regression leads to a lot of breakage (and cursing). OK patch applied let's see if I get it to Torvalds in time. Can I have some ACK from Maxime? Yours, Linus Walleij