From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5E6C4360F for ; Wed, 3 Apr 2019 03:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98FF220882 for ; Wed, 3 Apr 2019 03:52:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RyD78TZA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727641AbfDCDwI (ORCPT ); Tue, 2 Apr 2019 23:52:08 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:37249 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbfDCDwH (ORCPT ); Tue, 2 Apr 2019 23:52:07 -0400 Received: by mail-lj1-f196.google.com with SMTP id v13so13529370ljk.4 for ; Tue, 02 Apr 2019 20:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kg3WUa3CkCPyjjbhF0hOtQWsJmh9cExSsQakBS9fveI=; b=RyD78TZAxKA3ie7m03JtN5qUC8/Iaz6k16FIqQoqig2jPtyBVzCSxcMdJlEf+QEy90 dzJ2Thkf8UQknpto25seUQSk499WvnST8woBVeQ6BVEABrvJG3JHEl2U/eRMAueLNpLl oxrAAUdFwxrFxuqTXint1gEqfwYupcxzxj0J1bsLsG1hqh1lHCof9ZnhoZClIgkICUwS sUHLnuX9egFaXk42UT792I15F5+trizSv+b7G03SPFarEydfXA66yLU3OM2MCsegdqN5 davDZ5yIQOi30jGcvgcU1Rb9EYYm9CNLlclHE9bX4fJNyDhjM09ViKtTSjV0t5Qt3yoi lNQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kg3WUa3CkCPyjjbhF0hOtQWsJmh9cExSsQakBS9fveI=; b=QpFzXyMI3cc+8XVUdB4hVS6zbH1vsk1eXF6Jok5PiPvhMxEx/cFgcAU8DKqcMw33CQ QSVDVkWpcjguAcpy/kU+UZ/Y4Ffsd1Qcmspub5v+MluIlEM8KBN+q5HVEdJha6gJkBw7 K6YzR+JZyKIiamLXhoJPTeqiZa4IBH/rUyYyBVmD/5iE21fPCFTvDlk15YJqxMQplMfg ZpH0ufQjMl1nyinrqHdKrmalFcvSwrrxfE/+AufxYLOdnwbivGNwE1Hc81OzWudFn05r 9ET+RWOEhZk8HUeGrt0sw1zZ4qbX6rsS+A+5BahgRPqyDNGyCRv35AIxEDGp2447AXBZ 7wmA== X-Gm-Message-State: APjAAAV+mwZmKbcPCiqy/z7U6931wToNVRGN5BDNEhNsxPAwKEkpdVtC fOnZzwWuazacfu0vTffNklZcmITW0ey2/OEb/HjcJA== X-Google-Smtp-Source: APXvYqwu95SiNvGUSW3Na0JcXSGZvxzEgGJoSGGgx/uhoxot61MOWQd9qrZQucB2UWwmumcvfIt/NdzafNySEfCewpY= X-Received: by 2002:a2e:3512:: with SMTP id z18mr27125108ljz.25.1554263525916; Tue, 02 Apr 2019 20:52:05 -0700 (PDT) MIME-Version: 1.0 References: <1552330521-4276-1-git-send-email-info@metux.net> <1552330521-4276-38-git-send-email-info@metux.net> In-Reply-To: <1552330521-4276-38-git-send-email-info@metux.net> From: Linus Walleij Date: Wed, 3 Apr 2019 10:51:53 +0700 Message-ID: Subject: Re: [PATCH 38/42] drivers: gpio: vr41xx: use devm_platform_ioremap_resource() To: "Enrico Weigelt, metux IT consult" Cc: "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , Andrew Jeffery , Florian Fainelli , Scott Branden , bcm-kernel-feedback-list , Hoan Tran , Orson Zhai , Baolin Wang , Lyra Zhang , Keguang Zhang , Vladimir Zapolskiy , Matthias Brugger , "thierry.reding@gmail.com" , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Masahiro Yamada , Jun Nie , Shawn Guo , "open list:GPIO SUBSYSTEM" , linux-mips@vger.kernel.org, linux-pwm@vger.kernel.org, Linux-OMAP , linux-tegra@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 12, 2019 at 1:56 AM Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > this driver deserves a bit more cleanup, to get rid of the global > variable giu_base, which makes it single-instance-only. > > Signed-off-by: Enrico Weigelt, metux IT consult Holding this back until we have more consensus and some ACKs. Yours, Linus Walleij