From: Linus Walleij <linus.walleij@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>,
Paolo Valente <paolo.valente@linaro.org>,
Jens Axboe <axboe@fb.com>, Hannes Reinecke <hare@suse.com>,
Tejun Heo <tj@kernel.org>, Omar Sandoval <osandov@osandov.com>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
Baolin Wang <baolin.wang@linaro.org>,
Ritesh Harjani <riteshh@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Chunyan Zhang <zhang.chunyan@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-block@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH PoCv2 0/2] mmc: add blk-mq support
Date: Wed, 4 Jan 2017 11:18:14 +0100 [thread overview]
Message-ID: <CACRpkdYEqbpU0sc+-CvJh32hnrM0G=SYQBhb5r34ofmYyBoD3g@mail.gmail.com> (raw)
In-Reply-To: <1483464618-16133-1-git-send-email-b.zolnierkie@samsung.com>
On Tue, Jan 3, 2017 at 6:30 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
Interesting patch!
> The differences between these patches and Linus' RFD patch:
> - request completion is handled from the IRQ handler
> (or tasklet context as happens in dw_mmc host driver)
I think we need to make a patch like this separately to the
current (only old blk) code, to stop the kthread from forcing
in NULL requests to clean the pipeline.
We should also avoid sending any completion at
all: if we know we only get one request at a time as your
patch does, there is no reason to wait for a completion: we
will always be complete when a new request arrives.
Same with two requests in parallel, we can trust the block
layer to not send more than 2 (the queue depth) so there is
no reason to wait for a completion.
I'm trying to work in this direction at least, your patch is great
inspiration!
Yours,
Linus Walleij
prev parent reply other threads:[~2017-01-04 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170103173113epcas5p3bcc48e614ca71c27917a966640321138@epcas5p3.samsung.com>
2017-01-03 17:30 ` [PATCH PoCv2 0/2] mmc: add blk-mq support Bartlomiej Zolnierkiewicz
[not found] ` <CGME20170103173119epcas5p32d141b74cc44c2eb5197695d66829720@epcas5p3.samsung.com>
2017-01-03 17:30 ` [PATCH PoCv2 1/2] Revert "mmc: queue: Share mmc request array between partitions" Bartlomiej Zolnierkiewicz
2017-01-03 18:32 ` Greg KH
[not found] ` <CGME20170103173125epcas1p1c49a71464988f28a620ded304efd1807@epcas1p1.samsung.com>
2017-01-03 17:30 ` [PATCH PoCv2 2/2] mmc-mq: initial blk-mq support Bartlomiej Zolnierkiewicz
2017-01-04 10:18 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYEqbpU0sc+-CvJh32hnrM0G=SYQBhb5r34ofmYyBoD3g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Bart.VanAssche@sandisk.com \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=b.zolnierkie@samsung.com \
--cc=baolin.wang@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=paolo.valente@linaro.org \
--cc=riteshh@codeaurora.org \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).