From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B8CBC10F0E for ; Tue, 9 Apr 2019 07:35:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF3FF2083E for ; Tue, 9 Apr 2019 07:35:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qiY4oaPq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbfDIHfQ (ORCPT ); Tue, 9 Apr 2019 03:35:16 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:34978 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbfDIHfQ (ORCPT ); Tue, 9 Apr 2019 03:35:16 -0400 Received: by mail-lj1-f194.google.com with SMTP id t4so13547629ljc.2 for ; Tue, 09 Apr 2019 00:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=LwZvRAwjz4v8vPB24QlTXxeUwtfYiSirjEGXsASLuDU=; b=qiY4oaPqfTf3/T5SoWvYI3WlshrEYkpjv2JCk0cSXN0x3+9uYxuPhNpoaXzBdP/2pZ i3H02EljbkFGq/t3Y8IqsVkruIXLQXBoSVKplchUd8OqnaqZx+aI8/xwceEie3FvBDCD 94DmzuKY1qVSlkR1Kaj54A2mXNHpuFCrucKGgMAbK1TNPXv/yxqG/mMHGZTDuHTMcyJC 99ChYKuH6ggalX7x3ORcS6JTSHWq/GYZ9zIHVN2pbKck0INFDIbL6b7rpvNO5nMChIpi VFvs6Ia+ky6Rz7Ejuph8IKjM3RzSCE461aU2JnaQqUHopH7nzs2XFYBpFn8IvcGjstkF TVkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=LwZvRAwjz4v8vPB24QlTXxeUwtfYiSirjEGXsASLuDU=; b=KPIM44ykBvD+GlnkXXkoseRQdDSFvxZ/jtfmL445RccttZ0+HXDfG32jFfacAdrvYr OsjXwwG1gJvOotXpBtSSrmchJFaa+Sv9WB8aNeoHxcgzd1W+PxXDZJUooPFgQqaqLTcG HrJ57Cc3vTVhGxmFBsuOMCuamfKzFKv+0yy8n39FpKtZRg/nROH+Y8fScudYBe71EWZk rm3VWKa3qK8QJLzZFQMaM0uPcEsL2ETyGxiP0gAYq4OzngoYNfypeLw2w16tMihewzHn 1d3x7s8/Qgt02IJDdBuHUy06dBJWpXLcukGjxa7VVfJMbbm5nw9uj0rKAFp0105i6R40 IBQw== X-Gm-Message-State: APjAAAURWx47laomF8G/QN/BRtDMIW3QBrpJHZt/l5ubfCUdLf2STWek XYzH3hWF3T8tPf483n0Ebxsr2H17ldFhzaLSISjeRg== X-Google-Smtp-Source: APXvYqzfKNqys0GobM4u8jt3J6Oyk6PGtVt93Q142DP3RUNDDo20Kd4Qq4bUK7ups+7NTewIUvriXKCZWEUt9gzGB2A= X-Received: by 2002:a2e:9a46:: with SMTP id k6mr18301188ljj.119.1554795314005; Tue, 09 Apr 2019 00:35:14 -0700 (PDT) MIME-Version: 1.0 References: <20190405234514.6183-1-megous@megous.com> <20190405234514.6183-8-megous@megous.com> <20190408074042.74s5qckukcpore3e@flea> <20190408232232.fsl2ddthwo2rr4ql@core.my.home> In-Reply-To: <20190408232232.fsl2ddthwo2rr4ql@core.my.home> From: Linus Walleij Date: Tue, 9 Apr 2019 09:35:02 +0200 Message-ID: Subject: Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet To: Maxime Ripard , linux-sunxi , Chen-Yu Tsai , Rob Herring , Linus Walleij , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "linux-kernel@vger.kernel.org" , netdev , linux-stm32@st-md-mailman.stormreply.com, linux-wireless , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 9, 2019 at 1:22 AM Ond=C5=99ej Jirman wrote= : > > > + enable-active-high; > > > + gpio =3D <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ > > > > Is enable-active-high still needed? It's redundant with the > > GPIO_ACTIVE_HIGH flag. > > Looking at the code, use/non-use of enable-active-high inhibits > flags specified in gpio property. So the GPIO_ACTIVE_HIGH flag > is ignored here (had GPIO_ACTIVE_LOW been used, the kernel would > ignore it too and print a warning). > > So enable-active-high is still necessary here. > > See comment in gpiolib-of.c where this is handled: > > /* > * The regulator GPIO handles are specified such that the > * presence or absence of "enable-active-high" solely controls > * the polarity of the GPIO line. Any phandle flags must > * be actively ignored. > */ Yeah this caused me special headache in the current merge window because of buggy code on my part. This is an effect of this flag being defined for powerpc ages before we properly implemented generic GPIO bindings. We just have to respect it. See: https://marc.info/?l=3Dlinux-gpio&m=3D155417774822532&w=3D2 Yours, Linus Walleij