From: Linus Walleij <linus.walleij@linaro.org>
To: Zheng Bin <zhengbin13@huawei.com>
Cc: j.neuschaefer@gmx.net, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, tangyizhou@huawei.com
Subject: Re: [PATCH -next] pinctrl: nuvoton: wpcm450: Fix build error without OF
Date: Fri, 25 Mar 2022 21:15:39 +0100 [thread overview]
Message-ID: <CACRpkdYHKq+aSHzm6wG3ETwob69gmmjFT5UV7EXL0rDxe4ZQ=Q@mail.gmail.com> (raw)
In-Reply-To: <20220325074450.3228840-1-zhengbin13@huawei.com>
On Fri, Mar 25, 2022 at 8:30 AM Zheng Bin <zhengbin13@huawei.com> wrote:
> If OF is not set, bulding fails:
>
> drivers/pinctrl/nuvoton/pinctrl-wpcm450.o: In function `wpcm450_dt_node_to_map':
> pinctrl-wpcm450.c:(.text+0x404): undefined reference to `pinconf_generic_dt_node_to_map'
>
> Make PINCTRL_WPCM450 depends on OF to fix this.
>
> Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Patch applied, thanks for fixing this so quickly Zheng!
Yours,
Linus Walleij
prev parent reply other threads:[~2022-03-25 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 7:44 [PATCH -next] pinctrl: nuvoton: wpcm450: Fix build error without OF Zheng Bin
2022-03-25 20:15 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYHKq+aSHzm6wG3ETwob69gmmjFT5UV7EXL0rDxe4ZQ=Q@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=j.neuschaefer@gmx.net \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangyizhou@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).