From: Linus Walleij <linus.walleij@linaro.org>
To: "Jan Kundrát" <jan.kundrat@cesnet.cz>
Cc: Lars Poeschel <poeschel@lemonage.de>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH] pinctrl: mcp23s08: Allocate irq_chip dynamic
Date: Fri, 8 Mar 2019 10:15:50 +0100 [thread overview]
Message-ID: <CACRpkdYJHyj+TMOde=veQsj8m+xFf0XGEnT0DS0qgMXCSA5iOA@mail.gmail.com> (raw)
In-Reply-To: <7ce47f34-ed9f-44ac-b966-68e3bbf3b052@cesnet.cz>
On Tue, Mar 5, 2019 at 4:19 PM Jan Kundrát <jan.kundrat@cesnet.cz> wrote:
> This commit should probably go to 5.0-stable and 4.20-stable as well
I doubt that this commit is fixing a regression, but who knows...
> If I cherry-pick the following two commits to my 5.0, my board boots once
> again:
>
> 16f4372fd7a5 pinctrl: mcp23s08: use struct_size() in devm_kzalloc()
> 19ab5ca9b77d pinctrl: mcp23s08: Allocate irq_chip dynamic
Hm weird.
> As on "why am I hitting this while nobody else did", my board has a shared
> IRQ line which is active during bootup, perhaps that might have something
> to do with this -- I don't know.
Sounds like the code in mcp23s08 .probe() should write to all
registers clearing and disabling interrupts before proceeding to
request interrupts or register the irqchip, else it will fire immediately
and cause oopses.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-03-08 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 16:25 [PATCH] pinctrl: mcp23s08: Allocate irq_chip dynamic Lars Poeschel
2019-01-21 13:19 ` Linus Walleij
2019-03-05 15:19 ` Jan Kundrát
2019-03-08 9:15 ` Linus Walleij [this message]
2019-03-08 12:30 ` Jan Kundrát
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYJHyj+TMOde=veQsj8m+xFf0XGEnT0DS0qgMXCSA5iOA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=jan.kundrat@cesnet.cz \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=poeschel@lemonage.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).