From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFEECC7EE24 for ; Tue, 6 Jun 2023 19:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239456AbjFFTPk (ORCPT ); Tue, 6 Jun 2023 15:15:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239792AbjFFTPV (ORCPT ); Tue, 6 Jun 2023 15:15:21 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99384E54 for ; Tue, 6 Jun 2023 12:15:19 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-565aa2cc428so60644857b3.1 for ; Tue, 06 Jun 2023 12:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686078919; x=1688670919; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z5L89tB8wkQBFqziHGie36QGbrdPo8qwmA+HXjQV+vM=; b=Oubagn6lNYCvFolZHgBbvAxTse+fxYO7QOc8PsA9iZP9e2t8ETUtUWYpW1X4aol5Pp py6kevZaycKSmSBo4Z6ISBISiqD/7iIAwBWyBerIW3RreJJ9HEAvuTJFC1L1gIxClE8B Zo1Jho7S8zqD4w+aESDk8wwKPZczPNjCqaahODZegcGR0bAXcfGkhfpy0GiU9nZoxYH5 3tSmdOg9aItl0cd9p5EIa1kuQY2vPS7IZIU1+jsUKFLETbT+lwkEGP2w54vB26myg4Sn aFZsKajhIoQKKCk8+V/q1rcIuw5atboBqOS6WM8DoES2EgCSQ+vS7fzVbSeDtG9bQjao +WFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686078919; x=1688670919; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z5L89tB8wkQBFqziHGie36QGbrdPo8qwmA+HXjQV+vM=; b=SUbYaNw/0vEllS4yqyfGtFzr7XmiSH1oqkwaM75X6jyvg/D4o+x0Wqc1VmMeAKuZTE G2Lu8oE6XaqszUxyAJomwMUyxtyRafE9+rh/4RjFViASsfpigJIZ/jKVE6eibCtmayFu MFZtJHKcMhFNGmKt4uaeyyUp0mAATCcebLsn6WUnMl/7N6cCl+6WkNRIdWHCH/IM7zNp ljdvqu6bMM8KBc6Y2g5VWAPa+HRfNsBaJpxFJJqE6DP2ZwP87H6glaOJ7Nhb46jprLpo HkXQZeQN/vxRTQmEP38NRhZiSaabwYnw7etpbmjZ72PR4ShpUu2KWKxQTqP23LHwN211 VL3w== X-Gm-Message-State: AC+VfDyALDMl0HDIpC6mT+aV2MrYS2AULDxgg8yDmHa5HHBPVlx9zamZ vS+Ig4za2SiNdvMLT5qx0z8ABkGnhKeUQ1Ydiwl2nw== X-Google-Smtp-Source: ACHHUZ7lY+3AI76qpzpoSr0j2ZD5ERQQbLahw7zOYjKWi6Cuk/Te9kSx2WMaK6q/Ss77uvK92hSSK8RRBBpnLOmJ/uE= X-Received: by 2002:a81:52d3:0:b0:561:e565:3678 with SMTP id g202-20020a8152d3000000b00561e5653678mr2718930ywb.11.1686078918837; Tue, 06 Jun 2023 12:15:18 -0700 (PDT) MIME-Version: 1.0 References: <20230430-nokia770-regression-v4-0-9b6dc5536b17@linaro.org> <20230430-nokia770-regression-v4-1-9b6dc5536b17@linaro.org> In-Reply-To: From: Linus Walleij Date: Tue, 6 Jun 2023 21:15:07 +0200 Message-ID: Subject: Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes To: Christophe JAILLET Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Thomas Bogendoerfer , Dmitry Torokhov , Mark Brown , Bartosz Golaszewski , Andreas Kemnade , Helge Deller , Ulf Hansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mmc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 4, 2023 at 5:44=E2=80=AFPM Christophe JAILLET wrote: > > + /* Asserts RESET */ > > + gpiod_set_value(md->reset, 1); > > Hi, > > should this also be done in the probe if mipid_detect() fails? It's a nice bonus but surely not urgent or necessary. > If yes, please also look at [1], that I've just sent, which introduces > an error handling path in the probe. Looks good to me. Reviewed-by: Linus Walleij Yours, Linus Walleij