From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752415AbbC0KS0 (ORCPT ); Fri, 27 Mar 2015 06:18:26 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:36535 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbbC0KSW (ORCPT ); Fri, 27 Mar 2015 06:18:22 -0400 MIME-Version: 1.0 In-Reply-To: <1427222562-2223-1-git-send-email-grygorii.strashko@linaro.org> References: <20150324161358.GA694@kahuna> <1427222562-2223-1-git-send-email-grygorii.strashko@linaro.org> Date: Fri, 27 Mar 2015 11:18:21 +0100 Message-ID: Subject: Re: [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt From: Linus Walleij To: Grygorii Strashko Cc: Russell King - ARM Linux , Alexandre Courbot , Muralidharan Karicheri , Santosh Shilimkar , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 7:42 PM, wrote: > From: Grygorii Strashko > > Now GPIO syscon driver produces bunch of warnings during the > boot of Kesytone 2 SoCs: > gpio-syscon soc:keystone_dsp_gpio@02620240: can't read the dir register offset! > gpio-syscon soc:keystone_dsp_gpio@2620244: can't read the dir register offset! > > This message unintentionally was added using dev_err(), but its > actual log level is debug, because third cell of "ti,syscon-dev" is > optional. > > Hence change it to dev_dbg() as it should be. > > This patch fixes commit: > 5a3e3f8 ("gpio: syscon: retriave syscon node and regs offsets from dt") > > Reported-by: Russell King > Signed-off-by: Grygorii Strashko OK sorry for missing this when asking about the strange messages. Patch applied for fixes with these test tags and ack. Yours, Linus Walleij