From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA9BC4332D for ; Fri, 5 Mar 2021 10:26:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C706A64F6A for ; Fri, 5 Mar 2021 10:26:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbhCEK0G (ORCPT ); Fri, 5 Mar 2021 05:26:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbhCEKZc (ORCPT ); Fri, 5 Mar 2021 05:25:32 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6B37C06175F for ; Fri, 5 Mar 2021 02:25:31 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id k12so2065087ljg.9 for ; Fri, 05 Mar 2021 02:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=leQw7QODR4CyZQiZgP9OPt/5ZEqXQr46bOHgh0kpZlk=; b=iSUpKEpRqonYV1gt46fEBjz/fG1evvGP933Hm8NDO8DF1Nf82vxEvrPe92LonMVaj5 cDE4IcRvvO1ntfTn5itxZs+RgWOz8mw4hJMZdVy/8h2ViibMQXl1AgXPtgXQM11LX0a1 RhKFE3xqBC792VlT4JGclRKp0uaCgPW6l2Fb9cHIdP+2mUUor2Hr91JIg6O+aC5Fvdbf +dYsoxFLntrw49PjvfalTLzJsU9XYkeIK3tTqUIWRgHmgkKh6DAj/8G88mtElmj6EDwm mBuK4v6HFEIDG7XjAVIoY9pgDp6ULe7Abxl3AljZx0i4k7liqPevlL5AQL78ZahYYIdz kc3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=leQw7QODR4CyZQiZgP9OPt/5ZEqXQr46bOHgh0kpZlk=; b=JMaN9FCrD+Krw6bLT9+zZRDzTlVXo0ly2zCBOwdHqt1pJqoa89kMYTEqOg+b9k8zrg T2ynZeUIfp94G2SdOSUyR6qra+MSE2DubOq1DUoo2g1nSq67yrCmyBaICdvDP3Dz8MWY +GiRuntbU+KjJvWoyoDHIcWgJLMdZiGEmv9F9A6ob8WB5jgvf2eQjBTp/SZKrYfUKBgT 6ulXIzKa/bL8MkEwJyMdxYV2V0yjtEMqn4CWzL/6MCuIlhAc5rs2OjiisVVMpNCsopqi T6dKp5g3HUYdDBlVClLdg4dSxI+eeXEiWdG5MQqPVxs7Xv/gh9q3qBHX0RGrzqTM8myQ ElVw== X-Gm-Message-State: AOAM533mg5VXJLIbdAuY1sD+FRFs0I9940P43a/ejsNDceneywwzQa6A ttNc/z2qG6Vdcq+qQhtTwdWmV0xuyiJ3mnkuItCmGQ== X-Google-Smtp-Source: ABdhPJxsMc8mauXfaPMwsKihYulLxZ/6kfZ3EeDp5br7yesRj8HC0FjQsUqFiEGezYIKsMpnpQHfiXS3MNRkjkU9flk= X-Received: by 2002:a2e:700a:: with SMTP id l10mr4752980ljc.368.1614939930235; Fri, 05 Mar 2021 02:25:30 -0800 (PST) MIME-Version: 1.0 References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-11-marcan@marcan.st> In-Reply-To: <20210304213902.83903-11-marcan@marcan.st> From: Linus Walleij Date: Fri, 5 Mar 2021 11:25:19 +0100 Message-ID: Subject: Re: [RFT PATCH v3 10/27] docs: driver-api: device-io: Document ioremap() variants & access funcs To: Hector Martin Cc: Linux ARM , Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" , Linux Doc Mailing List , linux-samsung-soc , Linux-Arch , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 4, 2021 at 10:40 PM Hector Martin wrote: > This documents the newly introduced ioremap_np() along with all the > other common ioremap() variants, and some higher-level abstractions > available. > > Signed-off-by: Hector Martin I like this, I just want one change: Put the common ioremap() on top in all paragraphs, so the norm comes before the exceptions. I.e. it is weird to mention ioremap_np() before mentioning ioremap(). With that change: Reviewed-by: Linus Walleij Yours, Linus Walleij