From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE587C43460 for ; Fri, 30 Apr 2021 01:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B159B61412 for ; Fri, 30 Apr 2021 01:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbhD3B2u (ORCPT ); Thu, 29 Apr 2021 21:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhD3B2s (ORCPT ); Thu, 29 Apr 2021 21:28:48 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D54AEC06138D for ; Thu, 29 Apr 2021 18:27:59 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id 12so107407312lfq.13 for ; Thu, 29 Apr 2021 18:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5nYrcPFaE9JozlbdUYcBvuc3knwcBJ+KRlPBwjPg/eY=; b=mWr/LU95sxRmIHn3zRMbluegyGD2oe6oRt4d/eRVIdu7KE3Hz+geRyAZlmU7D5TMAP hBhqnVuVTVgUAhM0ZWa+OwuRT9bQbE3RnlfSljIXyeQtbRVE3csRBOvTZ2UblLcRM1QC xxs3hrrGH/TOp0oQcLOkEQIwojDLhahdEkZ6uo900/o8WZPZ19oj42KYditGQucez/as vUnwQLP3c6V6Z++gJIjubVeNlKS9+vW3LkRRxu3vS1WvzgEP3ZR5H+scAq2iwSyMhr+x AmUwvYqwpyzEIbU+VnqL+66wxLgWtk7TUMbBixNYKsUb9BMpCwEI2TAVauzbB6jQtiw3 Iexg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5nYrcPFaE9JozlbdUYcBvuc3knwcBJ+KRlPBwjPg/eY=; b=rpE/gDQ0mf3l6s0EZ4xP1sd9Mp30MghiEK6+2Gzdk5srcfUfXzi8CnyNs8pUnyNWFB KXRRkMRX4EpK32NT0MEn89VUwxzCuJpFoaJQ8tOEfNdzBKPnM7XIgecIZtfcq/ZRmwOe /Q25YjR9oV2OMfn8tH0L2JKZQgb5+mAPzLlZiurbpvOUEA+T3lFzbEqn5wCvMqTpzZi5 gFd31CQVwfz1iHKRv9PTWL90PfMuKoz5j2YnZN6v9V6YM/i7SCyYtQdqKxIykmcZRAJd vsfEukCy6HboubNpTNXGzy6yGd2PXsk9LhY/0SRtZ9alYDF7PfShgeH1kRk8pckQlLIn 0uTw== X-Gm-Message-State: AOAM532ZXVfg2i+iyoT0OY3Cnodjcc5lObf5Ds1klTZyg5wDhVlcNsp2 +pebEr5+Me3+L8ALxBEHzY/k/wy2F3eSOtNQZu2ajA== X-Google-Smtp-Source: ABdhPJzFPmRotZN0fnw8kLXHW0mhRMJ6Y9pLJGkfe+X4ux0/23qoEes3nema+045FI+84RCCCXHVaXcNwdXLrns0we4= X-Received: by 2002:a05:6512:149:: with SMTP id m9mr1218659lfo.157.1619746078186; Thu, 29 Apr 2021 18:27:58 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: From: Linus Walleij Date: Fri, 30 Apr 2021 03:27:47 +0200 Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Doug Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , MSM , Rob Clark , Stanislav Lisovskiy , Stephen Boyd , Steev Klimaszewski , Maarten Lankhorst , linux-i2c , Bjorn Andersson , "open list:DRM PANEL DRIVERS" , Daniel Vetter , David Airlie , Thierry Reding , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 30, 2021 at 3:25 AM Doug Anderson wrote: > > I think pm_runtime_disable(); need to be added there? > > I'm a bit confused. You're saying that I need to add > pm_runtime_disable() to panel_simple_remove()? Doesn't this patch do > that? It does, sorry, too late at night :D I was looking at the previous patch and mixed up which was the patch and the patch to the patch... Thanks, apply this! Linus Walleij