From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29663C433DF for ; Wed, 3 Jun 2020 12:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 084A720678 for ; Wed, 3 Jun 2020 12:33:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j5pGS0sa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbgFCMdH (ORCPT ); Wed, 3 Jun 2020 08:33:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgFCMdH (ORCPT ); Wed, 3 Jun 2020 08:33:07 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A926C08C5C1 for ; Wed, 3 Jun 2020 05:33:06 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id e4so2497901ljn.4 for ; Wed, 03 Jun 2020 05:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ABlOAalG07S3zJOvUC745+rY/SSKj3sE9WPw30YFDjU=; b=j5pGS0saNqzjuUTDnzk4gxvht5sf4S+tv6vSaLTyjDBARzg9FteZcdfRr8S1n9Haet qlFQ2ouaCalHfwiwuUpttmmqx1lTJngtw0F9PY46fo4d1TWbBYkBBagsnh9h6EQ9MVOc 6JyNNo3yHbaM81jiBNY2+r2j80yqy65HFeq5pkgjQzdX7SsIMAiAirPsJcSXZwWxfEm0 YPDGQJivsMU5zvIDpGScT/yfJu4/a6opRYcIDW6d0yGPuub/53PJ75c1pXgwScnhgJ4c 5XrQls/Q8rpqTV/GfeOdwaeFV1TiWN0KM+DqF6XIcKXI0szKCRijrky9/bgKeGp4OX8E Aqfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ABlOAalG07S3zJOvUC745+rY/SSKj3sE9WPw30YFDjU=; b=i7CUlDjqYYoQdbi0RIynVlN1P70iQyLkOWngkz902L2nGtnOD7jEXBos7xKS7FJSlo w9fy6RnWCOuMOjTZ9GG4GjFTRU3BbiVxaPej9U4l6qlRRMNkDOWwfP0wYcOr8RrJct9i gB0HpTvjrXcnty0ZWapP+F8fz4r5AkHpa1Jp1tuzLyGJZoJ6AlgzbrS58uJ3a02OTpyt hMypGFBLRZcf10/ZT1p+q4Pb6ZEcg0WrKHIRTJFvqeNkeTdeplMhjJmjzyWs7MAJB9/e WijKhUuZJ/+S0tfLEPRVbyguvIhZdlf6j0tey0MFiEQn+Ruyih3ZzX9SP8CrYa2FOAy/ gC7g== X-Gm-Message-State: AOAM531uGYtQjtsF93emMVseU/e7Y5osfcQ8UVkUSJDwea9rHp2CaL3B mHYZmZSAq67jtvgufPr0kNxAh8C8kTepQ1b6/TgdlA== X-Google-Smtp-Source: ABdhPJzG/VMlm4Q8bDM7mFUXZQxGPr6AbvJ8r2atD4zrWYykPr7kfUi4nWG5C+/LBdHXHq5+wgxQQwSQFcYGnOURAd4= X-Received: by 2002:a2e:350a:: with SMTP id z10mr1923491ljz.104.1591187584647; Wed, 03 Jun 2020 05:33:04 -0700 (PDT) MIME-Version: 1.0 References: <20200603013532.755220-1-yukuai3@huawei.com> In-Reply-To: <20200603013532.755220-1-yukuai3@huawei.com> From: Linus Walleij Date: Wed, 3 Jun 2020 14:32:53 +0200 Message-ID: Subject: Re: [PATCH V2] pinctrl: sirf: add missing put_device() call in sirfsoc_gpio_probe() To: yu kuai Cc: Barry Song , Yuping Luo , Markus Elfring , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , yi.zhang@huawei.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 3, 2020 at 3:36 AM yu kuai wrote: > A coccicheck run provided information like the following: > > drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device; > call of_find_device_by_node on line 792, but without a corresponding > object release within this function. > > Generated by: scripts/coccinelle/free/put_device.cocci > > Thus add a jump target to fix the exception handling for this > function implementation. > > Fixes: 5130216265f6 ("PINCTRL: SiRF: add GPIO and GPIO irq support in CSR SiRFprimaII") > Signed-off-by: yu kuai Patch applied, thanks! Yours, Linus Walleij