From: Linus Walleij <linus.walleij@linaro.org>
To: Drew Fustini <drew@beagleboard.org>
Cc: Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>,
Trent Piepho <tpiepho@gmail.com>,
Christina Quast <cquast@hanoverdisplays.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: single: fix pinctrl_spec.args_count bounds check
Date: Thu, 1 Oct 2020 10:03:08 +0200 [thread overview]
Message-ID: <CACRpkdYkxTiC9iMJV8SrMGXHU5jGut8vJ=1WQFK=avXd5PrE_w@mail.gmail.com> (raw)
In-Reply-To: <20200930174839.1308344-1-drew@beagleboard.org>
On Wed, Sep 30, 2020 at 7:51 PM Drew Fustini <drew@beagleboard.org> wrote:
> The property #pinctrl-cells can either be 1 or 2:
>
> - if #pinctrl-cells = <1>, then pinctrl_spec.args_count = 2
> - if #pinctrl-cells = <2>, then pinctrl_spec.args_count = 3
>
> All other values of pinctrl_spec.args_count are incorrect. This fix
> checks the upper bound instead of just the lower bound.
>
> Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2")
> Reported-by: Trent Piepho <tpiepho@gmail.com>
> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> - correct the description as I had previously been mistakenly using the
> term #pinctrl-cells instead of pinctrl_spec.args_count
Patch applied!
Yours,
Linus Walleij
prev parent reply other threads:[~2020-10-01 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 17:48 [PATCH v2] pinctrl: single: fix pinctrl_spec.args_count bounds check Drew Fustini
2020-10-01 7:31 ` Tony Lindgren
2020-10-01 8:03 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYkxTiC9iMJV8SrMGXHU5jGut8vJ=1WQFK=avXd5PrE_w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=cquast@hanoverdisplays.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).