From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754321AbdC1Jqg (ORCPT ); Tue, 28 Mar 2017 05:46:36 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:34892 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694AbdC1Jqd (ORCPT ); Tue, 28 Mar 2017 05:46:33 -0400 MIME-Version: 1.0 In-Reply-To: <20170323160204.GL30223@w540> References: <1490026491-21742-1-git-send-email-jacopo+renesas@jmondi.org> <1490026491-21742-3-git-send-email-jacopo+renesas@jmondi.org> <20170323160204.GL30223@w540> From: Linus Walleij Date: Tue, 28 Mar 2017 11:46:30 +0200 Message-ID: Subject: Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc To: jacopo Cc: Geert Uytterhoeven , Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2017 at 5:02 PM, jacopo wrote: >> > + Required properties: >> > + - renesas,pins >> >> Just "pins"? >> > > You know, I've been thinking about this, bu the "pins" property > definition in pinctrl-bidings is the following one: > > Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > --- > - pins takes a list of pin names or IDs as a required argument. The > specific binding for the hardware defines: > - Whether the entries are integers or strings, and their > meaning. > --- > > And all examples there assume one "pin name" or "ID" per pin. > > Now, we use 2 values per each pin (the pin ID and the alternate > function number), so to me this is different from what the generic > binding describes. > Also, pinctrl-single, and pinctrl-imx which have and ABI similar to > the one this driver define, use "pinctrl-single,pins" and "fsl,pins" > respectively as property names. > So either they have to be updated yet, or we should keep using > "renesas,pins" for our own defined ABI. > > Maybe Linus or other pinctrl people can give some suggestion here. To me as subsystem maintainer any "necessarily different" bindings are just a big confusion for the head. Since you're adding a new driver, try to stick to the generic bindings even if it deviates from what you are used to for Renesas, because even if it may be more work for you guys or make you annoyed that now a certain Renesas is different from all other Renesas platforms, for the community this makes things easier to maintain because we can look at the driver and its bindings and say "ah I know this". The fact that historically all the early adopters of pinctrl in device tree have these funky custom bindings is unfortunate but just something that we need to live with. Yours, Linus Walleij