* [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks
@ 2020-06-04 17:49 Vidya Sagar
2020-06-04 18:00 ` Dmitry Osipenko
2020-06-10 8:47 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Vidya Sagar @ 2020-06-04 17:49 UTC (permalink / raw)
To: linus.walleij, treding, jonathanh, digetx, skomatineni
Cc: linux-gpio, linux-tegra, linux-kernel, kthota, mmaddireddy,
vidyas, sagar.tv
Use noirq suspend/resume callbacks as other drivers which implement
noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to
configure the signals used by their respective devices in the noirq phase.
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 21661f6490d6..195cfe557511 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev)
}
const struct dev_pm_ops tegra_pinctrl_pm = {
- .suspend = &tegra_pinctrl_suspend,
- .resume = &tegra_pinctrl_resume
+ .suspend_noirq = &tegra_pinctrl_suspend,
+ .resume_noirq = &tegra_pinctrl_resume
};
static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks
2020-06-04 17:49 [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks Vidya Sagar
@ 2020-06-04 18:00 ` Dmitry Osipenko
2020-06-10 8:47 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2020-06-04 18:00 UTC (permalink / raw)
To: Vidya Sagar, linus.walleij, treding, jonathanh, skomatineni
Cc: linux-gpio, linux-tegra, linux-kernel, kthota, mmaddireddy, sagar.tv
04.06.2020 20:49, Vidya Sagar пишет:
> Use noirq suspend/resume callbacks as other drivers which implement
> noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to
> configure the signals used by their respective devices in the noirq phase.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 21661f6490d6..195cfe557511 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev)
> }
>
> const struct dev_pm_ops tegra_pinctrl_pm = {
> - .suspend = &tegra_pinctrl_suspend,
> - .resume = &tegra_pinctrl_resume
> + .suspend_noirq = &tegra_pinctrl_suspend,
> + .resume_noirq = &tegra_pinctrl_resume
> };
>
> static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
>
That's a good catch! Perhaps I2C on later Tegra SoCs also should suffer
similarly to the PCIe.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks
2020-06-04 17:49 [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks Vidya Sagar
2020-06-04 18:00 ` Dmitry Osipenko
@ 2020-06-10 8:47 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-06-10 8:47 UTC (permalink / raw)
To: Vidya Sagar
Cc: Thierry Reding, Jon Hunter, Dmitry Osipenko, Sowjanya Komatineni,
open list:GPIO SUBSYSTEM, linux-tegra, linux-kernel, kthota,
mmaddireddy, sagar.tv
On Thu, Jun 4, 2020 at 7:49 PM Vidya Sagar <vidyas@nvidia.com> wrote:
> Use noirq suspend/resume callbacks as other drivers which implement
> noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to
> configure the signals used by their respective devices in the noirq phase.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-10 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 17:49 [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks Vidya Sagar
2020-06-04 18:00 ` Dmitry Osipenko
2020-06-10 8:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).