From: Linus Walleij <linus.walleij@linaro.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: andrew@aj.id.au, joel@jms.id.au, linux-aspeed@lists.ozlabs.org,
openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: aspeed: Force to disable the function's signal
Date: Fri, 26 Aug 2022 23:56:50 +0200 [thread overview]
Message-ID: <CACRpkdYpp_1JJQmuX27pECxN0cjzciCuETLPTrSYKqpX0FPABQ@mail.gmail.com> (raw)
In-Reply-To: <20220818101839.28860-1-billy_tsai@aspeedtech.com>
On Thu, Aug 18, 2022 at 12:18 PM Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> When the driver want to disable the signal of the function, it doesn't
> need to query the state of the mux function's signal on a pin. The
> condition below will miss the disable of the signal:
> Ball | Default | P0 Signal | P0 Expression | Other
> -----+---------+-----------+-----------------------------+----------
> E21 GPIOG0 SD2CLK SCU4B4[16]=1 & SCU450[1]=1 GPIOG0
> -----+---------+-----------+-----------------------------+----------
> B22 GPIOG1 SD2CMD SCU4B4[17]=1 & SCU450[1]=1 GPIOG1
> -----+---------+-----------+-----------------------------+----------
> Assume the register status like below:
> SCU4B4[16] == 1 & SCU4B4[17] == 1 & SCU450[1]==1
> After the driver set the Ball E21 to the GPIOG0:
> SCU4B4[16] == 0 & SCU4B4[17] == 1 & SCU450[1]==0
> When the driver want to set the Ball B22 to the GPIOG1, the condition of
> the SD2CMD will be false causing SCU4B4[17] not to be cleared.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
I can't see the verdict for this patch? Will there be a new
version, or are we in the middle of a discussion?
I'd really like Andrew's ACK on the result before merging.
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-08-26 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 10:18 [PATCH] pinctrl: aspeed: Force to disable the function's signal Billy Tsai
2022-08-19 0:40 ` Andrew Jeffery
2022-08-23 10:51 ` Billy Tsai
2022-08-26 21:56 ` Linus Walleij [this message]
2022-08-26 22:48 ` Andrew Jeffery
2023-01-19 1:54 ` Joel Stanley
2023-01-21 12:32 ` Linux kernel regression tracking (#adding)
2023-02-15 14:52 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-01-27 12:38 ` Linus Walleij
2023-01-30 3:06 ` Joel Stanley
2023-01-30 4:33 ` Andrew Jeffery
2022-08-31 12:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYpp_1JJQmuX27pECxN0cjzciCuETLPTrSYKqpX0FPABQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).