From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdILHkl (ORCPT ); Tue, 12 Sep 2017 03:40:41 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:38105 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbdILHkk (ORCPT ); Tue, 12 Sep 2017 03:40:40 -0400 X-Google-Smtp-Source: AOwi7QD6mkms4nm9Gg761nLUvhYNf1Dvha0GN71JamjpVg04ks0vDXiTFKZpM5gBfFG0nYBrA0P5JWPvn27u82DwPp0= MIME-Version: 1.0 In-Reply-To: <20170905075826.893066-1-arnd@arndb.de> References: <20170905075826.893066-1-arnd@arndb.de> From: Linus Walleij Date: Tue, 12 Sep 2017 09:40:39 +0200 Message-ID: Subject: Re: [PATCH 1/2] pinctrl: sprd: add missing Kconfig dependency To: Arnd Bergmann , Randy Dunlap Cc: Baolin Wang , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 5, 2017 at 9:58 AM, Arnd Bergmann wrote: > The chip-specific driver fails to build when the common > part is not enabled first: > > drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x8): undefined reference to `sprd_pinctrl_remove' > drivers/pinctrl/sprd/pinctrl-sprd-sc9860.o:(.data+0x10): undefined reference to `sprd_pinctrl_shutdown' > > This adds a Kconfig dependency to ensure this is always > the case. > > Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver") > Signed-off-by: Arnd Bergmann I got a fix for this and the other problem from Randy Dunlap already. Thanks anyway! Yours, Linus Walleij