archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <>
To: Dmitry Torokhov <>
Cc: Andy Shevchenko <>,
	Andreas Kemnade <>,
	"open list:GPIO SUBSYSTEM" <>,
	linux-spi <>,
	"" <>
Subject: Re: [PATCH] gpiolib: of: fix fallback quirks handling
Date: Tue, 10 Sep 2019 11:33:32 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190903231856.GA165165@dtor-ws>

On Wed, Sep 4, 2019 at 12:18 AM Dmitry Torokhov
<> wrote:

> We should only try to execute fallback quirks handling when previous
> call returned -ENOENT, and not when we did not get -EPROBE_DEFER.
> The other errors should be treated as hard errors: we did find the GPIO
> description, but for some reason we failed to handle it properly.
> The fallbacks should only be executed when previous handlers returned
> -ENOENT, which means the mapping/description was not found.
> Also let's remove the explicit deferral handling when iterating through
> GPIO suffixes: it is not needed anymore as we will not be calling
> fallbacks for anything but -ENOENT.
> Fixes: df451f83e1fc ("gpio: of: fix Freescale SPI CS quirk handling")
> Signed-off-by: Dmitry Torokhov <>

Patch applied with Andy's review tag.

Sorry for not catching this before, the reasoning with the patch
is correct and I should have noticed. Overload I guess.

Linus Walleij

      parent reply	other threads:[~2019-09-10 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 23:18 [PATCH] gpiolib: of: fix fallback quirks handling Dmitry Torokhov
2019-09-04 12:34 ` Andy Shevchenko
2019-09-10 10:33 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).