From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756755Ab3KHJGQ (ORCPT ); Fri, 8 Nov 2013 04:06:16 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:61423 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562Ab3KHJGL (ORCPT ); Fri, 8 Nov 2013 04:06:11 -0500 MIME-Version: 1.0 In-Reply-To: <20131107120742.GP30901@lee--X1> References: <1383732348-18576-1-git-send-email-lee.jones@linaro.org> <1383732348-18576-4-git-send-email-lee.jones@linaro.org> <20131107120742.GP30901@lee--X1> Date: Fri, 8 Nov 2013 10:06:08 +0100 Message-ID: Subject: Re: [PATCH 3/7] ARM: ux500: Remove ATAG support for SDI (MMC) From: Linus Walleij To: Lee Jones Cc: Ulf Hansson , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 7, 2013 at 1:07 PM, Lee Jones wrote: >> > -struct mmci_platform_data mop500_sdi0_data = { >> > - .f_max = 100000000, >> > - .capabilities = MMC_CAP_4_BIT_DATA | >> > - MMC_CAP_SD_HIGHSPEED | >> > - MMC_CAP_MMC_HIGHSPEED | >> > - MMC_CAP_ERASE | >> > - MMC_CAP_UHS_SDR12 | >> > - MMC_CAP_UHS_SDR25, >> >> I guess all the above caps is having binders in DT then? > > They're not there yet, no. But this stuff is not used anymore in > Mainline hence the patch. I attempted to supply bindings for them, but > they were rejected. Would you like to have a stab at that? Yeah but we basically regressed the ux500 with the patch now queued for v3.13: commit 49c129519a7a8840767321c38d2eaf84a263529b "ARM: ux500: Stop passing MMC's platform data for Device Tree boots" Which deleted the passing of this non-yet-DT:ed platform data. Since it's a regression we need to do a fixup patch for the v3.13 series adding it back. Since this patch probably needs to be rewritten on top of that I don't merge this patch as of now. Yours, Linus Walleij