From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430AbcKHIpy (ORCPT ); Tue, 8 Nov 2016 03:45:54 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:36585 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbcKHIpv (ORCPT ); Tue, 8 Nov 2016 03:45:51 -0500 MIME-Version: 1.0 In-Reply-To: <1478537603-23653-12-git-send-email-andrew.smirnov@gmail.com> References: <1478537603-23653-1-git-send-email-andrew.smirnov@gmail.com> <1478537603-23653-12-git-send-email-andrew.smirnov@gmail.com> From: Linus Walleij Date: Tue, 8 Nov 2016 09:45:50 +0100 Message-ID: Subject: Re: [PATCH v2 11/15] pinctrl-sx150x: Improve oscio GPIO functions To: Andrey Smirnov Cc: "linux-gpio@vger.kernel.org" , Neil Armstrong , "linux-kernel@vger.kernel.org" , Chris Healy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 7, 2016 at 5:53 PM, Andrey Smirnov wrote: > Move actual code that configures oscio pin into a separate function and > use it instead of calling sx150x_gpio_set to avoid calling > sx150x_pin_is_oscio twice and correctly propagte error code in > sx150x_gpio_direction_output. > > Tested-by: Neil Armstrong > Acked-by: Neil Armstrong > Signed-off-by: Andrey Smirnov Patch applied! Yours, Linus Walleij