From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5BDC43217 for ; Thu, 23 Sep 2021 21:48:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDAA961214 for ; Thu, 23 Sep 2021 21:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243388AbhIWVuT (ORCPT ); Thu, 23 Sep 2021 17:50:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243291AbhIWVuR (ORCPT ); Thu, 23 Sep 2021 17:50:17 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71227C061574 for ; Thu, 23 Sep 2021 14:48:45 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id t10so31842905lfd.8 for ; Thu, 23 Sep 2021 14:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7FkpkRmKHqmPvFFREorMPwFdCCRcl6RFgYu4s9yiDfM=; b=V3EyYY2zZCCc3qurGlNx4ZlXLarvbqI9nr5hfYuyzB4wEmeUbF40YeZ3zAtxzDXEcK +t5/DnvFsnyMuYCa0KlgKwbFNuhL50Gpr8mdzijTcgutDXFE8abM1gVoeNcMkWT6A7M+ zR3JSdoEhJTF6qk/WRbDbkWp2sivoJ0Vg/y2RUPkzfSl45P12ZAAvJ+sqOxFGNsL0AYo Krfq3aM1bvkTXIgCS4kQp0fC1yJ80UuOvRa2DRcDQcI/4cin9bTM3aaX/4jS+vY/3xcd FASXGIMHKWi8CBviYumU8po1T4UYtss2mOxNyBo69a20/Ue2KN/RAyTlIpJqolLOWZfK Q6JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7FkpkRmKHqmPvFFREorMPwFdCCRcl6RFgYu4s9yiDfM=; b=t3UaryVpPJ7fjF0xnsOf6A5k7KR98Gq0NY1rg2KgqKWNs2JIF4uL7xxqo8PwT85kfk WUa3zVJhajW71VbgzowoR3OUuHDmvmcA+yXpaVTj/HnPBzI6NmtMQi8S9kHBnKU6PT0m skv33WNyKFc670wSGz+nwrM+IkCLn+zZQw/Dcf1uxMwcBK33ofguOgI67Rlgyml9jrct rAehCDD5sPkr1oSw6++gFHJ9kgHKYJ/H4K4ZRc0nQ0A3efMBW7GeeLyk18ypJZtv841c 3SAMd3mccwB7bYdtSShTA3lgDivISemTEmW/zXZUL6KFUvahi0qY1lAU1tppZducPdmF t6mw== X-Gm-Message-State: AOAM530Rpb//4+s1655pODxYS7/XgTnoDjBdOSHz2CCrdCHcAdWfxZdB DedcI7wbW7vV4/E6Xhbl84rQZrGZMacBj9XayuKk3w== X-Google-Smtp-Source: ABdhPJzRJ6lk2udBuzr9FrKwJZvK0C0NBFG8pHIWz3jIt1r/+I+/7dijGUv6MSez/cEvzFz71CddyZXKEEOMFuxPPL0= X-Received: by 2002:a05:651c:4d2:: with SMTP id e18mr7656983lji.432.1632433723807; Thu, 23 Sep 2021 14:48:43 -0700 (PDT) MIME-Version: 1.0 References: <20210921043936.468001-1-andrew@aj.id.au> In-Reply-To: <20210921043936.468001-1-andrew@aj.id.au> From: Linus Walleij Date: Thu, 23 Sep 2021 23:48:33 +0200 Message-ID: Subject: Re: [PATCH 0/2] leds: pca955x: Expose GPIOs for all pins To: Andrew Jeffery Cc: Linux LED Subsystem , "open list:GPIO SUBSYSTEM" , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Rob Herring , Joel Stanley , Pavel Machek , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-aspeed , linux-kernel , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 6:39 AM Andrew Jeffery wrote: > 1. Contains no (ab)use of pinctrl > 2. Always exposes all pins as GPIOs > 3. Internally tracks the active pins Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij