From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760348AbcBYKAc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Feb 2016 05:00:32 -0500
Received: from mail-oi0-f54.google.com ([209.85.218.54]:33994 "EHLO
	mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759336AbcBYKA3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Feb 2016 05:00:29 -0500
MIME-Version: 1.0
In-Reply-To: <1456209934-13439-1-git-send-email-a.hajda@samsung.com>
References: <1456209934-13439-1-git-send-email-a.hajda@samsung.com>
Date: Thu, 25 Feb 2016 11:00:29 +0100
Message-ID: <CACRpkdYxnmOkkWksWE+-eGa-J3hNNqU=GHC7xA4mhEyyye4Htg@mail.gmail.com>
Subject: Re: [PATCH 1/2] gpio: xgene: fix type of variable containing error codes
From: Linus Walleij <linus.walleij@linaro.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 23, 2016 at 7:45 AM, Andrzej Hajda <a.hajda@samsung.com> wrote:

> ret variable can contain error values and is compared with zero.
> Its type must be signed.
>
> The problem has been detected using coccinelle script
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>

Patch applied as obviously correct.

Yours,
Linus Walleij