From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161418AbcFHIKc (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jun 2016 04:10:32 -0400
Received: from mail-oi0-f54.google.com ([209.85.218.54]:34527 "EHLO
	mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1161246AbcFHIKU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jun 2016 04:10:20 -0400
MIME-Version: 1.0
In-Reply-To: <1464924495-20375-1-git-send-email-hongkun.cao@mediatek.com>
References: <1464924495-20375-1-git-send-email-hongkun.cao@mediatek.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 8 Jun 2016 10:10:19 +0200
Message-ID: <CACRpkdZ18pvNBLp1L4wBh2BnwODaju4mTwCjuK-Bnp-Rc5feqA@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: mediatek: fix suspend/resume timing issue
To: hongkun.cao@mediatek.com
Cc: Rob Herring <robh+dt@kernel.org>,
        =?UTF-8?Q?Pawe=C5=82_Moll?= <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Erin Lo <erin.lo@mediatek.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        srv_heupstream@mediatek.com,
        Hongzhou Yang <hongzhou.yang@mediatek.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Sudeep Holla <sudeep.holla@arm.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 3, 2016 at 5:28 AM,  <hongkun.cao@mediatek.com> wrote:

> From: "hongkun.cao" <hongkun.cao@mediatek.com>
>
> An irq which is a wake up source maybe masked unexpectedly if the wake
> up source irq was triggered after pinctrl irqchip suspend and before
> suspend_device_irqs finished.
> Use *_noirq callbacks to guarantee pinctrl irqchip suspend would be
> called after suspend_devices_irqs.
>
> Signed-off-by: hongkun.cao <hongkun.cao@mediatek.com>

No rreaction from the other maintainers but it looks correct to me
so patch applied.

Yours,
Linus Walleij