From: Linus Walleij <linus.walleij@linaro.org>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Russell King <rmk+kernel@armlinux.org.uk>,
Nadav Haklai <nadavh@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Neta Zur Hershkovits <neta@marvell.com>,
Marcin Wojtas <mw@semihalf.com>, Omri Itach <omrii@marvell.com>,
Shadi Ammouri <shadi@marvell.com>,
Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
Ralph Sennhauser <ralph.sennhauser@gmail.com>
Subject: Re: [PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage
Date: Fri, 16 Jun 2017 11:18:38 +0200 [thread overview]
Message-ID: <CACRpkdZ2LuT50EMMOuT_FO0pz0nmO_fWhoBJd+Q76STWOpPNFA@mail.gmail.com> (raw)
In-Reply-To: <9a098130daa8daeef89fd6c1e80d982699d5c175.1497281623.git-series.gregory.clement@free-electrons.com>
On Mon, Jun 12, 2017 at 5:34 PM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:
> In some place in the driver regmap_update_bits was misused. Indeed the
> last argument is not the value of the bit (or group of bits) itself but
> the mask value inside the register.
>
> So when setting the bit N, then the value must be BIT(N) and not 1.
>
> CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
> CC: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Tested-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> Tested-by: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Already applied this patch, sorry for missing the resend in the series.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-06-16 9:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 15:34 [PATCH v3 0/9] Add support for the pin and gpio controllers on the Marvell Armada 7K/8K Gregory CLEMENT
2017-06-12 15:34 ` [PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT
2017-06-16 9:18 ` Linus Walleij [this message]
2017-06-12 15:34 ` [PATCH v3 2/9] pinctrl: mvebu: remove the offset property for regmap Gregory CLEMENT
2017-06-16 9:20 ` Linus Walleij
2017-06-12 15:34 ` [PATCH v3 3/9] pinctrl: avoid PLAT_ORION dependency Gregory CLEMENT
2017-06-16 9:21 ` Linus Walleij
2017-06-12 15:34 ` [PATCH v3 4/9] arm64: marvell: enable the Armada 7K/8K pinctrl driver Gregory CLEMENT
2017-06-16 9:22 ` Linus Walleij
2017-06-21 12:53 ` Gregory CLEMENT
2017-06-12 15:34 ` [PATCH v3 5/9] pinctrl: mvebu: add driver for Armada AP806 pinctrl Gregory CLEMENT
2017-06-16 9:23 ` Linus Walleij
2017-06-12 15:34 ` [PATCH v3 6/9] pinctrl: mvebu: add driver for Armada CP110 pinctrl Gregory CLEMENT
2017-06-16 9:24 ` Linus Walleij
2017-06-16 9:26 ` Linus Walleij
2017-06-12 15:34 ` [PATCH v3 7/9] arm64: dts: marvell: add pinctrl support for Armada 7K/8K Gregory CLEMENT
2017-06-20 14:34 ` Gregory CLEMENT
2017-06-12 15:34 ` [PATCH v3 8/9] gpio: mvebu: Add support for the Armada 7K/8K SoCs Gregory CLEMENT
2017-06-16 9:29 ` Linus Walleij
2017-06-12 15:35 ` [PATCH v3 9/9] arm64: dts: marvell: add gpio support for Armada 7K/8K Gregory CLEMENT
2017-06-20 14:34 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ2LuT50EMMOuT_FO0pz0nmO_fWhoBJd+Q76STWOpPNFA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kostap@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=neta@marvell.com \
--cc=omrii@marvell.com \
--cc=ralph.sennhauser@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shadi@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).