From: Linus Walleij <linus.walleij@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] gpio: rcar: Use wakeup_path i.s.o. explicit clock handling
Date: Thu, 22 Feb 2018 15:23:03 +0100 [thread overview]
Message-ID: <CACRpkdZ4oPmc5ithggUVMd6_MStMLs59mi3yV4e+ym4UgF5H5A@mail.gmail.com> (raw)
In-Reply-To: <1518443713-1835-4-git-send-email-geert+renesas@glider.be>
On Mon, Feb 12, 2018 at 2:55 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable
> when wake-up is enabled"), when a GPIO is used for wakeup, the GPIO
> block's module clock (if exists) is manually kept running during system
> suspend, to make sure the device stays active.
>
> However, this explicit clock handling is merely a workaround for a
> failure to properly communicate wakeup information to the device core.
>
> Instead, set the device's power.wakeup_path field, to indicate this
> device is part of the wakeup path. Depending on the PM Domain's
> active_wakeup configuration, the genpd core code will keep the device
> enabled (and the clock running) during system suspend when needed.
> This allows for the removal of all explicit clock handling code from the
> driver.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Can I apply this and only this patch to GPIO?
Should it be applied for fixes, next?
Else please funnel this through the irqchip tree with my
ACK.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-02-22 14:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 13:55 [PATCH v3 0/3] renesas: irqchip: Use wakeup_path i.s.o. explicit clock handling Geert Uytterhoeven
2018-02-12 13:55 ` [PATCH v3 1/3] irqchip/renesas-intc-irqpin: " Geert Uytterhoeven
2018-02-12 13:55 ` [PATCH v3 2/3] irqchip/renesas-irqc: " Geert Uytterhoeven
2018-02-12 13:55 ` [PATCH v3 3/3] gpio: rcar: " Geert Uytterhoeven
2018-02-22 14:23 ` Linus Walleij [this message]
2018-02-22 14:44 ` Geert Uytterhoeven
2018-03-01 16:06 ` Linus Walleij
2018-03-02 8:20 ` Geert Uytterhoeven
2018-03-02 8:44 ` Linus Walleij
2018-02-12 14:40 ` [PATCH v3 0/3] renesas: irqchip: " Ulf Hansson
2018-03-01 16:12 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ4oPmc5ithggUVMd6_MStMLs59mi3yV4e+ym4UgF5H5A@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=geert+renesas@glider.be \
--cc=jason@lakedaemon.net \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).