From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85582C433E6 for ; Fri, 12 Feb 2021 09:27:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FB7164E79 for ; Fri, 12 Feb 2021 09:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbhBLJ1k (ORCPT ); Fri, 12 Feb 2021 04:27:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbhBLJ1c (ORCPT ); Fri, 12 Feb 2021 04:27:32 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 291BBC061574 for ; Fri, 12 Feb 2021 01:26:52 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id e18so10706297lja.12 for ; Fri, 12 Feb 2021 01:26:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tYyTdHiOphi5wy20sCohGohSDGJFzJ14qi5hSzM5U+A=; b=Wo5odOySF/CFjO72mwfuehexVpDt5boeTBrjIi8eYdCX5x91Ji2sDZLyQY0eiM1n7J JR2GkNIaK5Y3PyjM+xg4Dkaublh/xAdcOhoNGhuS5QTsZikUhv+DZprC9Q25ghrVeerl jh2sYwpMfJcWeG1pUt0h6qPLrHnYxwzUpkWdWKWmYwNcWDRRILxxRh/P87sZR8ZIHQMB dqqwC1BFHhlq+4x++uWHc6z4Cl4Pse2K7iluG4dEEQ0pCh6UylDjSgKVkQ2kr/SjbCQo exvFjK6ZWi2hKR9YxMWiLG449QDlyi1psLns9RExwklkzgPexbJ4O198qXtn4aOou7Ff m9zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tYyTdHiOphi5wy20sCohGohSDGJFzJ14qi5hSzM5U+A=; b=l7zGFEaQWDYO78E2ud5eB2tXraOrxpCuUeIhOfoLvkiB3b7lF+fiv6gMO/qsUG/2wZ RiVmOSpoyAO+hCRv8UCo1tJYCBuUoHzrPUPe0Sr/OCnNf+QSCtWqljjutnGGyO0ITuQE NJzkoiNgbiUJY0Br6nPMeotcc2TzfY/43zxFnOlLR5Cix+rLEUGvsHjPOT6Pa+xYnkzk ZZBgNpN4Bas7pcWXMQ9mpiQHXK7ZSp8lilHNL73FFw9IbLTF8BfCdT/IE44ZOXPD0gUm i9F98HKL7X0p8OeK/KPIeHypgjoIEMkRaCdHoxaAZiLN5NKfNVjQ4Ru2IciMdCX/SZIX Peow== X-Gm-Message-State: AOAM532EWOdaHhldZ9I4Jgyak40MWlqt0xcLU3DcD7liT3+X1uRwZ7L6 wewEBlBGikSpM5F7bQ3Azt45Rz04m67uhkrEUdy+FA== X-Google-Smtp-Source: ABdhPJyTM3mAjXEWmeU9qHDaKPjX79dsGxohgA/kWmyN9gOGAk4Q6lBeaCJkUYRDfjmJdhz1GKgMtr5vBbKYhePpE30= X-Received: by 2002:a2e:6c17:: with SMTP id h23mr1222875ljc.326.1613122010712; Fri, 12 Feb 2021 01:26:50 -0800 (PST) MIME-Version: 1.0 References: <20210208135347.18494-1-o.rempel@pengutronix.de> <20210208135347.18494-3-o.rempel@pengutronix.de> In-Reply-To: <20210208135347.18494-3-o.rempel@pengutronix.de> From: Linus Walleij Date: Fri, 12 Feb 2021 10:26:39 +0100 Message-ID: Subject: Re: [PATCH v5 2/2] counter: add IRQ or GPIO based event counter To: Oleksij Rempel Cc: Rob Herring , William Breathitt Gray , Ahmad Fatoum , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team , David Jander , Robin van der Gracht , linux-iio , Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 8, 2021 at 2:53 PM Oleksij Rempel wrote: > Add simple IRQ or GPIO base event counter. This device is used to measure > rotation speed of some agricultural devices, so no high frequency on the > counter pin is expected. > > The maximal measurement frequency depends on the CPU and system load. On > the idle iMX6S I was able to measure up to 20kHz without count drops. > > Signed-off-by: Oleksij Rempel > Reviewed-by: Ahmad Fatoum >From GPIO and interrupt point of view this driver looks good to me. I don't know about the userspace interface etc. Yours, Linus Walleij