From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DAEC432BE for ; Wed, 11 Aug 2021 13:00:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27EB1600CD for ; Wed, 11 Aug 2021 13:00:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231204AbhHKNA0 (ORCPT ); Wed, 11 Aug 2021 09:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbhHKNAZ (ORCPT ); Wed, 11 Aug 2021 09:00:25 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55BB8C0613D3 for ; Wed, 11 Aug 2021 06:00:01 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id u13so4426130lje.5 for ; Wed, 11 Aug 2021 06:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9raAqstWOInQ9wyq7hxk8+0JIk+Aqi4dpxjqntVgY9s=; b=hSt4vFrly2JM0QO77mUcjMzkwID5HUv9zx2/fnjGZpyM5NU5ocYo3MiAvNMAneOy5P 9fF5ttXF7kO4BUFNtiD9aLc0q1fnZTSROd/MrBd8KHalQsmgjOt1NrImFI7Nv3PEPaOY l9TvpD7+X4OqMEMWbwvWmV2jUJ6Wbd1dACgStSNGjwebuJaGfSmcBkUfWPksQWcxURLp bfcTl0wo6llDCRyS0C8seQ9CsDRHz/ramTZS78J12PritcrY0Evmd1t17StEFFoATj8t 4ayNtje9TR1YNPCb1/ay0r7QH7ME5i9rYhskX1ufGxq2cz1gdHrU0nJDO5REzEtejZ2g hOvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9raAqstWOInQ9wyq7hxk8+0JIk+Aqi4dpxjqntVgY9s=; b=gnGfSagYvrqR0+FWfAJYiRmHruIYlDeM5EaErUhlgPxx3TLr8weQVfY30ZEOe+PaNz pwRH6f5lpKQigcn0XUtOQR1fD+kAgPmbPLqhzWJZ6I8uFY+4RdBtNzq6Y39tzKee4HbT UHYZZy5rLLPTDS2Mu44DD3IY8eTQQUnOieQ8cvdqlE4M7vNFlsaovMpicgICHr2BjSCB cycA6MciXNmAFFfzfeBqzQwjKoL6r6ZxRtegxjNGzMhbL1AWpSAfBUJWBjNxVe7cysJ7 hvTtaht8b+LuJ7Xe29NJKsS6w+W6s1FR3tdB9zQv/r559t47pDXhscJdnr7Hrmh1AX9q CfaQ== X-Gm-Message-State: AOAM532ssZDMkTtE8NW8q6LEYkRbv+Zv8Ke1Sz0U0IkvK6ruQiA/RkGC ux1i+r+hLrnW5fTEMhN4A3drsIP/OIRdLrmJAk0Hvw== X-Google-Smtp-Source: ABdhPJwV/uG/04abyCsQhn5zh7oybmy1PdQiJD1sQ3DMsjOyJF2lWHqAFGDKKUKrSqetQFxhFJMg7BK+lIkMfq08R5M= X-Received: by 2002:a05:651c:327:: with SMTP id b7mr23677504ljp.74.1628686799738; Wed, 11 Aug 2021 05:59:59 -0700 (PDT) MIME-Version: 1.0 References: <20210805174219.3000667-1-piyush.mehta@xilinx.com> <20210805174219.3000667-4-piyush.mehta@xilinx.com> In-Reply-To: <20210805174219.3000667-4-piyush.mehta@xilinx.com> From: Linus Walleij Date: Wed, 11 Aug 2021 14:59:48 +0200 Message-ID: Subject: Re: [PATCH V2 3/3] gpio: modepin: Add driver support for modepin GPIO controller To: Piyush Mehta Cc: Arnd Bergmann , Zou Wei , Greg KH , Michal Simek , wendy.liang@xilinx.com, Nobuhiro Iwamatsu , Bartosz Golaszewski , Rob Herring , rajan.vaja@xilinx.com, "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , git , Srinivas Goud , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Piyush, thanks for your patch! Can you explain one thing to me: since this is now a GPIO driver that means "General Purpos Input/Output", then these bits are accessed like this: On Thu, Aug 5, 2021 at 7:43 PM Piyush Mehta wrote: > + ret = zynqmp_pm_bootmode_read(&bootpin_val); This does not look very general purpose. These seem to be all about boot mode, right? So can you explain why this should be a GPIO driver at all? I understand it is sometimes convenient to describe stuff as GPIO even if it is not (for example to get a convenient userspace interface) but as maintainers we really need to make sure that the subsystem is not being abused for things not GPIO. Yours, Linus Walleij