* [PATCH] pinctrl: bcm2835: Use define directive for BCM2835_PINCONF_PARAM_PULL
@ 2018-11-01 0:46 Nathan Chancellor
2018-11-01 8:18 ` Stefan Wahren
2018-11-09 9:23 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2018-11-01 0:46 UTC (permalink / raw)
To: Linus Walleij
Cc: Eric Anholt, Stefan Wahren, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list, linux-gpio,
linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Nick Desaulniers, Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another:
drivers/pinctrl/bcm/pinctrl-bcm2835.c:707:40: warning: implicit
conversion from enumeration type 'enum bcm2835_pinconf_param' to
different enumeration type 'enum pin_config_param' [-Wenum-conversion]
configs[0] = pinconf_to_config_packed(BCM2835_PINCONF_PARAM_PULL, pull);
~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
It is expected that pinctrl drivers can extend pin_config_param because
of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion
isn't an issue. Most drivers that take advantage of this define the
PIN_CONFIG variables as constants, rather than enumerated values. Do the
same thing here so that Clang no longer warns.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index fa530913a2c8..b035c3fc0471 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -72,10 +72,8 @@
#define GPIO_REG_OFFSET(p) ((p) / 32)
#define GPIO_REG_SHIFT(p) ((p) % 32)
-enum bcm2835_pinconf_param {
- /* argument: bcm2835_pinconf_pull */
- BCM2835_PINCONF_PARAM_PULL = (PIN_CONFIG_END + 1),
-};
+/* argument: bcm2835_pinconf_pull */
+#define BCM2835_PINCONF_PARAM_PULL (PIN_CONFIG_END + 1)
struct bcm2835_pinctrl {
struct device *dev;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: bcm2835: Use define directive for BCM2835_PINCONF_PARAM_PULL
2018-11-01 0:46 [PATCH] pinctrl: bcm2835: Use define directive for BCM2835_PINCONF_PARAM_PULL Nathan Chancellor
@ 2018-11-01 8:18 ` Stefan Wahren
2018-11-09 9:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2018-11-01 8:18 UTC (permalink / raw)
To: Nathan Chancellor, Linus Walleij
Cc: Eric Anholt, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, linux-gpio, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, Nick Desaulniers
Am 01.11.18 um 01:46 schrieb Nathan Chancellor:
> Clang warns when one enumerated type is implicitly converted to another:
>
> drivers/pinctrl/bcm/pinctrl-bcm2835.c:707:40: warning: implicit
> conversion from enumeration type 'enum bcm2835_pinconf_param' to
> different enumeration type 'enum pin_config_param' [-Wenum-conversion]
> configs[0] = pinconf_to_config_packed(BCM2835_PINCONF_PARAM_PULL, pull);
> ~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 warning generated.
>
> It is expected that pinctrl drivers can extend pin_config_param because
> of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion
> isn't an issue. Most drivers that take advantage of this define the
> PIN_CONFIG variables as constants, rather than enumerated values. Do the
> same thing here so that Clang no longer warns.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: bcm2835: Use define directive for BCM2835_PINCONF_PARAM_PULL
2018-11-01 0:46 [PATCH] pinctrl: bcm2835: Use define directive for BCM2835_PINCONF_PARAM_PULL Nathan Chancellor
2018-11-01 8:18 ` Stefan Wahren
@ 2018-11-09 9:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-11-09 9:23 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Eric Anholt, Stefan Wahren, Florian Fainelli, Ray Jui,
Scott Branden, bcm-kernel-feedback-list,
open list:GPIO SUBSYSTEM, linux-rpi-kernel, Linux ARM,
linux-kernel, Nick Desaulniers
On Thu, Nov 1, 2018 at 1:47 AM Nathan Chancellor
<natechancellor@gmail.com> wrote:
> Clang warns when one enumerated type is implicitly converted to another:
>
> drivers/pinctrl/bcm/pinctrl-bcm2835.c:707:40: warning: implicit
> conversion from enumeration type 'enum bcm2835_pinconf_param' to
> different enumeration type 'enum pin_config_param' [-Wenum-conversion]
> configs[0] = pinconf_to_config_packed(BCM2835_PINCONF_PARAM_PULL, pull);
> ~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 warning generated.
>
> It is expected that pinctrl drivers can extend pin_config_param because
> of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion
> isn't an issue. Most drivers that take advantage of this define the
> PIN_CONFIG variables as constants, rather than enumerated values. Do the
> same thing here so that Clang no longer warns.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Patch applied with Stefan's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-09 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 0:46 [PATCH] pinctrl: bcm2835: Use define directive for BCM2835_PINCONF_PARAM_PULL Nathan Chancellor
2018-11-01 8:18 ` Stefan Wahren
2018-11-09 9:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).