From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4781C2D0C3 for ; Mon, 16 Dec 2019 10:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9983D206CB for ; Mon, 16 Dec 2019 10:30:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MNDQAaFQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727513AbfLPKaI (ORCPT ); Mon, 16 Dec 2019 05:30:08 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:37453 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727391AbfLPKaI (ORCPT ); Mon, 16 Dec 2019 05:30:08 -0500 Received: by mail-lf1-f65.google.com with SMTP id b15so3828322lfc.4 for ; Mon, 16 Dec 2019 02:30:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zAZ66aTL4botjOAzyywFJUSCyL81NlmcXv7uzteZ4R8=; b=MNDQAaFQhnjUWeVovtaucXzv5IniCaNpgTqcGXFx4jLe9x12jIYadC1PDnKMkPQDMK l2ehosXgsMnxhudijyOvnJ+2vzbUWEIeHPFUriZ0paYwJfnoOn54P2B+sQklEVWVQcw4 1T13ARTxSHB4SWDKf+zLThCGQ1iXcfpXnb6ACQsNk7u2HJXgpABr6a2qReZ5vfuS007z NjpK9Bhvzu5DQHSzVNXdv0/U8izrlloNKK1hMI5lpzL6sQzLwNTL1SIjwhP6Zna7Ivxv ewXg9sokgFFnzWqgeMrYd7orbCOiTcx9is4y2ZlEFFndxObGz4NfhSy7ItC3L8XppQCW Mw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zAZ66aTL4botjOAzyywFJUSCyL81NlmcXv7uzteZ4R8=; b=S3V7DwTkWPJCx0TAD6LNLLV4bzuJ8DPJyzgcoHIbY+cccRy3lmYByvUihtCGDGl8tw sKtZZWsOhnkOWpySEaQw0OfYczjTj0WqDz2/N6qnZZ2uh1pa2QgzARorwF3ErOEOBmN8 U4nixLaHK+56pJKgYqouVvt9TOXiCNqw0Au8h9fBYoezzw0oxoxJNpHPM3AklLwppIR2 8R06TqjqakFtWThUreHNEh56Gj4lF5m2ohxyd1YEnuBbJaAdqTmfMmQt2i4PZ1Z/H6uD MLkYGZobRGngF6rfJcsGEYss/g6lOZU55wrR2/j07sLYDlH82IhQo2X1Yn3Eh13aSSgE SQBA== X-Gm-Message-State: APjAAAXOpU5dQTK+q8EY3qabRjogsu0JHXJF8F5MvuQU8Ptju4FXTmdv IELEi023WoTkq8H5LI0fL9FyiW2yh6rcIE25h9qzHg== X-Google-Smtp-Source: APXvYqxlD1vfPmZyf5Z5diCSQWuPAUZ5VXeaBxCzjkY1MrbIYOP/373nkrVwCGdhAD+O1kDqu2EG46B1jbTPzJyZdoo= X-Received: by 2002:ac2:4945:: with SMTP id o5mr15738312lfi.93.1576492205964; Mon, 16 Dec 2019 02:30:05 -0800 (PST) MIME-Version: 1.0 References: <20191215163810.52356-1-hdegoede@redhat.com> <20191215163810.52356-6-hdegoede@redhat.com> In-Reply-To: <20191215163810.52356-6-hdegoede@redhat.com> From: Linus Walleij Date: Mon, 16 Dec 2019 11:29:54 +0100 Message-ID: Subject: Re: [PATCH 5/5] drm/i915/dsi: Control panel and backlight enable GPIOs on BYT To: Hans de Goede Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Lee Jones , intel-gfx , "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 15, 2019 at 5:38 PM Hans de Goede wrote: > On Bay Trail devices the MIPI power on/off sequences for DSI LCD panels > do not control the LCD panel- and backlight-enable GPIOs. So far, when > the VBT indicates we should use the SoC for backlight control, we have > been relying on these GPIOs being configured as output and driven high by > the Video BIOS (GOP) when it initializes the panel. > > This does not work when the device is booted with a HDMI monitor connected > as then the GOP will initialize the HDMI instead of the panel, leaving the > panel black, even though the i915 driver tries to output an image to it. > > Likewise on some device-models when the GOP does not initialize the DSI > panel it also leaves the mux of the PWM0 pin in generic GPIO mode instead > of muxing it to the PWM controller. > > This commit makes the DSI code control the SoC GPIOs for panel- and > backlight-enable on BYT, when the VBT indicates the SoC should be used > > for backlight control. It also ensures that the PWM0 pin is muxed to the > PWM controller in this case. > > This fixes the LCD panel not lighting up on various devices when booted > with a HDMI monitor connected. This has been tested to fix this on the > following devices: > > Peaq C1010 > Point of View MOBII TAB-P800W > Point of View MOBII TAB-P1005W > Terra Pad 1061 > Yours Y8W81 > > Signed-off-by: Hans de Goede Looks good to me: Reviewed-by: Linus Walleij Yours, Linus Walleij