From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752598AbcFNTiG (ORCPT ); Tue, 14 Jun 2016 15:38:06 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:35675 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbcFNTiD (ORCPT ); Tue, 14 Jun 2016 15:38:03 -0400 MIME-Version: 1.0 In-Reply-To: <20160614185108.GF28218@codeaurora.org> References: <1465897725-16213-1-git-send-email-linus.walleij@linaro.org> <20160614185108.GF28218@codeaurora.org> From: Linus Walleij Date: Tue, 14 Jun 2016 21:38:01 +0200 Message-ID: Subject: Re: [PATCH] mfd: qcom_rpm: fix offset error for msm8660 To: Stephen Boyd Cc: Lee Jones , "linux-kernel@vger.kernel.org" , Bjorn Andersson , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2016 at 8:51 PM, Stephen Boyd wrote: > On 06/14, Linus Walleij wrote: >> -#define RPM_REQUEST_CONTEXT 3 >> -#define RPM_REQ_SELECT 11 >> -#define RPM_ACK_CONTEXT 15 >> -#define RPM_ACK_SELECTOR 23 >> #define RPM_SELECT_SIZE 7 > > The RPM_SELECT_SIZE is 7 on 8660, but now you've pointed out that > otherwise the size is 4. I think you've uncovered another bug. OMG you're right. I'll send a v2 fixing that too. >> - RPM_CTRL_REG(rpm, RPM_REQ_SELECT + i)); >> + RPM_CTRL_REG(rpm, rpm->data->req_sel_off + i)); > > Here we write from 0 to ARRAY_SIZE(sel_mask) which is 7. That > would mean we write into the ack context that starts at 15 (we > start writing at req_sel_off which is always 11). Oops. Argh well it seems it didn't hurt so far but let's have it fixed. Yours, Linus Walleij