From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25BC8C433DB for ; Thu, 25 Mar 2021 09:18:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBE1A619D5 for ; Thu, 25 Mar 2021 09:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbhCYJRr (ORCPT ); Thu, 25 Mar 2021 05:17:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbhCYJRV (ORCPT ); Thu, 25 Mar 2021 05:17:21 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7851CC06175F for ; Thu, 25 Mar 2021 02:17:21 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id f26so2184119ljp.8 for ; Thu, 25 Mar 2021 02:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xtgWxHl1jBWFbgD+kv6AqSAbbwppmDLPyH8H5SEmUxY=; b=WYB7Cc3r/N8toO5HEXS4WvgZdy7e4DisDnlKJSVDlcwRznNZr3R/C2SKilRf8Rq4gj XHXoF+BOQkpgxnV2TcAs34RQwe1fA8xFgqxIpMXhF1+dsrccNXqaAz7GzmHsHMqSuDy3 IXW8OETtw3Ehwes1LhfsJ1pwTAGJMfokwcUPGs2r4AoSlCaNeP7qxiXwSyUZ977FKt14 SnqDCSgG3EDkOi51SUY8P3o6l2L4JU9POOt3xCt0GpVmKeJhSjh7XbSP41jy75enhdr0 k1oVi8IQoNFyb7OQVJ61YCvuwnuO1P9bmHBFL7i0EbBDWR9UTS/lw7+hy0kdy5U5A8jq TcAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xtgWxHl1jBWFbgD+kv6AqSAbbwppmDLPyH8H5SEmUxY=; b=FOQFh+ESM+8vPSPGk+2vzRocq5kv1HoF+/f5IzPfnToiJ57da3hnAViI0mXhjrw8GH eXXV9vOrTzFjiekB9oSJvEzKsmmAl65EKwh3RT0/JA1xI5xeLIFaCf+x/8bYdqw1Wnff wvTUOCa0K8nXk1rU0imdy5CNpX1fnf4ia8DivythxlQKQOc76Wa9rH7x+wcanIh2ysFu uCHH35RdMmAm7eQTvN05whvuaGGHFFMN2It9EN4aNbxEJfThdZAZ253+No9rkoB6MTS4 FBugjiQM7DZMhQy9yvVBVnUhVx0AjYpjxbhVpwA13avT8YxR+MhN3EimOKheHu011XeC rkow== X-Gm-Message-State: AOAM532e74S3lOTJfrMomb2l6tSzUTnf1x+mmU5sam+uLZiMFQ0jqPW4 uRXQutqpthM0NuIMVlwJuFd754XATQUA+24ETLKOug== X-Google-Smtp-Source: ABdhPJztjGrwBtJbNrrNxBR/yEEBoi4BB8Tjr78VRoOeWtyAz1JU3+GYgpMwR4+Idq17mB80FNZQyb4r6pcliq6jXLo= X-Received: by 2002:a2e:1649:: with SMTP id 9mr5210204ljw.74.1616663840040; Thu, 25 Mar 2021 02:17:20 -0700 (PDT) MIME-Version: 1.0 References: <20210316134059.2377081-1-geert+renesas@glider.be> In-Reply-To: <20210316134059.2377081-1-geert+renesas@glider.be> From: Linus Walleij Date: Thu, 25 Mar 2021 10:17:09 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: PINCTRL_ROCKCHIP should depend on ARCH_ROCKCHIP To: Geert Uytterhoeven Cc: Heiko Stuebner , Jianqun Xu , "open list:GPIO SUBSYSTEM" , "open list:ARM/Rockchip SoC..." , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 2:41 PM Geert Uytterhoeven wrote: > The Rockchip GPIO and pin control modules are only present on Rockchip > SoCs. Hence add a dependency on ARCH_ROCKCHIP, to prevent asking the > user about this driver when configuring a kernel without Rockchip > platform support. > > Note that before, the PINCTRL_ROCKCHIP symbol was not visible, and > automatically selected when needed. By making it tristate and > user-selectable, it became visible for everyone. > > Fixes: be786ac5a6c4bf4e ("pinctrl: rockchip: make driver be tristate module") > Signed-off-by: Geert Uytterhoeven Patch applied. I saw this was causing issues on S390. Yours, Linus Walleij