From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932918Ab2IRMLA (ORCPT ); Tue, 18 Sep 2012 08:11:00 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:54844 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757451Ab2IRMIN (ORCPT ); Tue, 18 Sep 2012 08:08:13 -0400 MIME-Version: 1.0 In-Reply-To: <505757D8.8090405@antcom.de> References: <1347016499-29354-1-git-send-email-lee.jones@linaro.org> <1347016499-29354-10-git-send-email-lee.jones@linaro.org> <505757D8.8090405@antcom.de> Date: Tue, 18 Sep 2012 14:08:12 +0200 Message-ID: Subject: Re: [PATCH 09/19] ARM: ux500: Enable SSP (SPI) for HREF when booting Device Tree From: Linus Walleij To: Roland Stigge Cc: Lee Jones , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, devicetree-discuss@lists.ozlabs.org, Gabriel FERNANDEZ , spi mailing list Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2012 at 7:03 PM, Roland Stigge wrote: > On 09/10/2012 01:11 PM, Linus Walleij wrote: >> >> It appears Roland has written his bindings such that DT >> data augments platform data (yes, I am also getting crazy >> about this prioritization, mea culpa for ACKing this without >> proper discussion) so it appears that you could actually >> use AUXDATA and some stuff in the DT at the same >> time. > > Sorry for the incompleteness of the devicetree conversion. I'm sending a > patch (separately) that makes it possible to specify everything via > devicetree, so you can choose between dt and platform data. OK it was not such a big deal, but many many thanks for fixing this up! :-) > Except in case of callback specification (dma_filter()), you need to > provide platform data. OK. > Interestingly, when I removed the actual platform data from the board > file, I noticed that I still needed to specify a device name (like > dev:ssp0) to make it work. But this seems to be expected according to > the documentation of OF_DEV_AUXDATA(). Are there any plans or ideas how > to fix this? This is very likely because the clock tree has a name like "dev:ssp0" encoded for this device, and if you don't nail it down like that the device name will be the same as the node in your device tree and then clock lookup will fail. The "real fix" is to convert the clock drivers to use device tree so the drivers can just refer to the phandles to figure out what clock node they need. Along with the DMA channel mapping this is one of the major roadblocks to finalizing the device tree adoptions. > When we have sorted out this driver change (please check the new pl022 > specific dt property names!), I will provide patches for arm-soc to > actually use this new interface via dts files. OK cool I guess you will do this for the LPC32xx? Or are you testing this on some other platforms? Yours, Linus Walleij