From: Linus Walleij <linus.walleij@linaro.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"open list:WOLFSON MICROELECTRONICS DRIVERS"
<patches@opensource.wolfsonmicro.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 11/17] pinctrl: madera: Add driver for Cirrus Logic Madera codecs
Date: Fri, 9 Jun 2017 11:13:34 +0200 [thread overview]
Message-ID: <CACRpkdZNT-isP4-1boWP2WBYMahrbB3SHO9PfubKhLE+BPTHTA@mail.gmail.com> (raw)
In-Reply-To: <1496415790-19164-12-git-send-email-rf@opensource.wolfsonmicro.com>
On Fri, Jun 2, 2017 at 5:03 PM, Richard Fitzgerald
<rf@opensource.wolfsonmicro.com> wrote:
> These codecs have a variable number of I/O lines each of which
> is individually selectable to a wide range of possible functions.
>
> The functionality is slightly different from the traditional muxed
> GPIO since most of the functions can be mapped to any pin (and even
> the same function to multiple pins). Most pins have a dedicated
> "alternate" function that is only available on that pin. The
> alternate functions are usually a group of signals, though it is
> not always necessary to enable the full group, depending on the
> alternate function and how it is to be used. The mapping between
> alternate functions and GPIO pins varies between codecs depending
> on the number of alternate functions and available pins.
>
> Note on the Kconfig options:
> The formula "default y if..." is used for PINCTRL_MADERA so that its
> select options will be processed, allowing us to group selects for
> pinctrl into the pinctrl Kconfig where they logically belong instead
> of accumulating under the parent MFD Kconfig.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
> Changes since V2:
> - Removed unused drive strength settings to tidy the code
> - Use devm_pinctrl_register_and_init() to avoid the problems with
> pinctrl_register()
> - Replaced a couple of hardcoded masks with the defined constant
There is a Kconfig problem as pointed out by the build robot.
Apart from that this looks like merge material, and we need to
think about a merge strategy like with the GPIO patch, once
the MFD portions are ready.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-06-09 9:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:02 [PATCH v3 00/17] Add support for Cirrus Logic CS47L35/L85/L90/L91 codecs Richard Fitzgerald
2017-06-02 15:02 ` [PATCH v3 01/17] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Richard Fitzgerald
2017-06-05 10:07 ` Lee Jones
2017-06-26 8:33 ` Richard Fitzgerald
2017-06-28 19:26 ` Mark Brown
2017-06-29 9:11 ` Richard Fitzgerald
2017-06-30 12:35 ` Mark Brown
2017-07-03 10:33 ` Lee Jones
2017-07-03 10:52 ` Joe Perches
2017-07-03 11:21 ` Lee Jones
2017-07-03 11:26 ` Joe Perches
2017-06-02 15:02 ` [PATCH v3 02/17] mfd: madera: Add DT bindings " Richard Fitzgerald
2017-06-05 10:13 ` Lee Jones
2017-06-08 19:12 ` Rob Herring
2017-06-02 15:02 ` [PATCH v3 03/17] mfd: madera: Add common support " Richard Fitzgerald
2017-06-05 10:32 ` Lee Jones
2017-06-05 10:40 ` Joe Perches
2017-06-02 15:02 ` [PATCH v3 04/17] mfd: madera: Register map tables for Cirrus Logic CS47L35 Richard Fitzgerald
2017-06-05 10:33 ` Lee Jones
2017-06-02 15:02 ` [PATCH v3 05/17] mfd: madera: Register map tables for Cirrus Logic CS47L85 Richard Fitzgerald
2017-06-05 10:33 ` Lee Jones
2017-06-05 10:42 ` Joe Perches
2017-06-02 15:02 ` [PATCH v3 06/17] mfd: madera: Register map tables for Cirrus Logic CS47L90/91 Richard Fitzgerald
2017-06-05 10:05 ` Lee Jones
2017-06-02 15:03 ` [PATCH v3 07/17] regulator: arizona-micsupp: Add support for Cirrus Logic Madera codecs Richard Fitzgerald
2017-06-05 17:10 ` Rob Herring
2017-07-27 11:45 ` [alsa-devel] " Richard Fitzgerald
2017-07-27 15:05 ` Mark Brown
2017-06-02 15:03 ` [PATCH v3 08/17] regulator: arizona-ldo1: " Richard Fitzgerald
2017-06-02 15:03 ` [PATCH v3 09/17] irqchip: Add driver " Richard Fitzgerald
2017-06-02 15:03 ` [PATCH v3 10/17] pinctrl: madera: Add DT bindings " Richard Fitzgerald
2017-06-08 19:15 ` Rob Herring
2017-06-02 15:03 ` [PATCH v3 11/17] pinctrl: madera: Add driver " Richard Fitzgerald
2017-06-03 0:26 ` [alsa-devel] " kbuild test robot
2017-06-09 9:13 ` Linus Walleij [this message]
2017-06-02 15:03 ` [PATCH v3 12/17] gpio: madera: Support Cirrus Logic Madera class codecs Richard Fitzgerald
2017-06-09 9:08 ` Linus Walleij
2017-06-02 15:03 ` [PATCH v3 13/17] ASoC: madera: Add DT bindings for Cirrus Logic Madera codecs Richard Fitzgerald
2017-06-08 19:17 ` Rob Herring
2017-06-02 15:03 ` [PATCH v3 14/17] ASoC: madera: Add common support " Richard Fitzgerald
2017-06-02 15:03 ` [PATCH v3 15/17] ASoC: cs47l35: Add codec driver for Cirrus Logic CS47L35 Richard Fitzgerald
2017-06-02 15:03 ` [PATCH v3 16/17] ASoC: cs47l85: Add codec driver for Cirrus Logic CS47L85 Richard Fitzgerald
2017-06-02 15:03 ` [PATCH v3 17/17] ASoC: cs47l90: Add codec driver for Cirrus Logic CS47L90 Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZNT-isP4-1boWP2WBYMahrbB3SHO9PfubKhLE+BPTHTA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jason@lakedaemon.net \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).